From c21cb143806b19287de5d0371345bab2193cfc27 Mon Sep 17 00:00:00 2001
From: Dorian Merz <merz@ub.uni-leipzig.de>
Date: Wed, 3 Mar 2021 14:27:15 +0100
Subject: [PATCH] refs #19252 [finc] replace PHP tags in finc theme

---
 .../data-additionalAuthors.phtml              |  4 ++--
 .../RecordDriver/DefaultRecord/data-bk.phtml  |  8 ++++----
 .../DefaultRecord/format-list.phtml           |  2 +-
 .../templates/RecordTab/holdingsils.phtml     |  2 +-
 .../RecordTab/holdingsils/standard.phtml      |  2 +-
 themes/finc/templates/admin/i18n/home.phtml   | 20 +++++++++----------
 .../templates/error/RuntimeException.phtml    |  2 +-
 .../templates/error/TimeoutException.phtml    |  2 +-
 8 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/themes/finc/templates/RecordDriver/DefaultRecord/data-additionalAuthors.phtml b/themes/finc/templates/RecordDriver/DefaultRecord/data-additionalAuthors.phtml
index 17ba1d06e62..88e85350234 100644
--- a/themes/finc/templates/RecordDriver/DefaultRecord/data-additionalAuthors.phtml
+++ b/themes/finc/templates/RecordDriver/DefaultRecord/data-additionalAuthors.phtml
@@ -2,11 +2,11 @@
 <?php if (!empty($data)): ?>
   <?php if (is_array($data)): ?>
     <?php foreach ($data as $author): ?>
-      <? if(isset($author['name'])): ?>
+      <?php if(isset($author['name'])): ?>
         <a href="<?=$this->record($this->driver)->getLink('author', $author['name'])?>">
           <?= $author['name'] ?>
         </a>
-      <? endif; ?>
+      <?php endif; ?>
       <?php if(isset($author['dates'])): ?>
         <?= $author['dates'] ?>
       <?php endif; ?>
diff --git a/themes/finc/templates/RecordDriver/DefaultRecord/data-bk.phtml b/themes/finc/templates/RecordDriver/DefaultRecord/data-bk.phtml
index d7b19e2baab..7a2d568a59d 100644
--- a/themes/finc/templates/RecordDriver/DefaultRecord/data-bk.phtml
+++ b/themes/finc/templates/RecordDriver/DefaultRecord/data-bk.phtml
@@ -1,6 +1,6 @@
 <!-- finc: RecordDriver - SolrMarc - data-bk -->
-<? if (!(empty($data))): ?>
-<? $i = 0; foreach ($data as $item): ?>
+<?php if (!(empty($data))): ?>
+<?php $i = 0; foreach ($data as $item): ?>
     <?= ($i++ == 0) ? '' : '<br>'; ?>
     <?php //ToDo: add link to embed bk notation search via search type on upcoming solr field
     /*
@@ -21,6 +21,6 @@
             echo $output;
         }
     ?>
-<? endforeach; ?>
-<? endif; ?>
+<?php endforeach; ?>
+<?php endif; ?>
 <!-- finc: RecordDriver - SolrMarc - data-bk - END -->
\ No newline at end of file
diff --git a/themes/finc/templates/RecordDriver/DefaultRecord/format-list.phtml b/themes/finc/templates/RecordDriver/DefaultRecord/format-list.phtml
index 584cc603b7f..b70be7192cb 100644
--- a/themes/finc/templates/RecordDriver/DefaultRecord/format-list.phtml
+++ b/themes/finc/templates/RecordDriver/DefaultRecord/format-list.phtml
@@ -21,6 +21,6 @@ foreach ($formats as $format): ?>
         ?>
         <span class="format"><?=$translated_genre?></span>
       <?php endif; ?>
-    <? endforeach; ?>
+    <?php endforeach; ?>
   <?php endif; ?>
 <?php endif; */ ?>
diff --git a/themes/finc/templates/RecordTab/holdingsils.phtml b/themes/finc/templates/RecordTab/holdingsils.phtml
index 90f4cd7d4eb..2a1b7d38980 100644
--- a/themes/finc/templates/RecordTab/holdingsils.phtml
+++ b/themes/finc/templates/RecordTab/holdingsils.phtml
@@ -155,7 +155,7 @@ if (!empty($holdingTitleHold)): ?>
         </td>
       </tr>
     <?php endforeach; endif; ?>
-    <? /* finc: we use call numbers after "Notes" - END */ ?>
+    <?php /* finc: we use call numbers after "Notes" - END */ ?>
     <?php if (!empty($holding['purchase_history'])): ?>
       <tr>
         <th><?=$this->transEsc("Most Recent Received Issues")?>:</th>
diff --git a/themes/finc/templates/RecordTab/holdingsils/standard.phtml b/themes/finc/templates/RecordTab/holdingsils/standard.phtml
index 5c1c993c792..edfcdba974e 100644
--- a/themes/finc/templates/RecordTab/holdingsils/standard.phtml
+++ b/themes/finc/templates/RecordTab/holdingsils/standard.phtml
@@ -51,7 +51,7 @@
             <i class="fa fa-flag"></i>&nbsp;<?= $this->transEsc($checkEmailHold ? "EmailHold::email_hold_check_text" : "EmailHold::email_hold_place_text") ?>
           </a>
         <?php endif; ?>
-        <? /* finc-specific insert - #6096 - END */ ?>
+        <?php /* finc-specific insert - #6096 - END */ ?>
       <?php else: ?>
         <?php /* Begin Unavailable Items (Recalls) */ ?>
         <?php /* finc: use empty status and transEsc 'Unavailable', CK */ ?>
diff --git a/themes/finc/templates/admin/i18n/home.phtml b/themes/finc/templates/admin/i18n/home.phtml
index 754d5e61924..1742553be46 100644
--- a/themes/finc/templates/admin/i18n/home.phtml
+++ b/themes/finc/templates/admin/i18n/home.phtml
@@ -1,5 +1,5 @@
 <!-- finc: admin - i18n - home -->
-<? $this->headTitle($this->translate('admin_i18n_menu_entry')); ?>
+<?php $this->headTitle($this->translate('admin_i18n_menu_entry')); ?>
 
 <div class="<?= ($this->layoutClass('mainbody') . (!$this->config()->get('config')->Site->admin_enabled ? ' solo' : '')) ?>">
     <h1><?= $this->transEsc('admin_i18n_menu_entry') ?></h1>
@@ -13,22 +13,22 @@
     <form id="change-language-form" action="<?= $this->url('admin/i18n') ?>">
         <div class="form-group">
             <p><strong><?= $this->transEsc('admin_i18n_select_languages') ?>:</strong></p>
-            <? foreach ($this->languages as $language): ?>
-                <? $checked = $language['selected'] ? 'checked' : ''; ?>
+            <?php foreach ($this->languages as $language): ?>
+                <?php $checked = $language['selected'] ? 'checked' : ''; ?>
                 <label class="checkbox-inline">
                     <input type="radio" name="locale" <?= $checked ?> value="<?= $language['locale'] ?>">
                     <?= $language['name'] ?>
                 </label>
-            <? endforeach; ?>
+            <?php endforeach; ?>
         </div>
         <div class="form-group">
             <p><strong><?= $this->transEsc('admin_i18n_select_domains') ?>:</strong></p>
-            <? foreach ($domains as $domain): ?>
+            <?php foreach ($domains as $domain): ?>
                 <label class="checkbox-inline">
                     <input type="radio" name="domain" value="<?= $domain['name'] ?>"<?= $domain['selected'] ? 'checked' : '' ?>>
                     <?= $domain['name'] ?>
                 </label>
-            <? endforeach; ?>
+            <?php endforeach; ?>
         </div>
         <button type="submit" form="change-language-form"
                 class="btn btn-primary">
@@ -76,11 +76,11 @@
     </table>
 </div>
 
-<? if ($this->config()->get('config')->Site->admin_enabled): ?>
+<?php if ($this->config()->get('config')->Site->admin_enabled): ?>
   <div class="<?= $this->layoutClass('sidebar') ?>">
     <?= $this->render("admin/menu.phtml") ?>
   </div>
-<? endif; ?>
+<?php endif; ?>
 
 <?php
 $script = <<<JS
@@ -108,9 +108,9 @@ $script = <<<JS
 JS;
 ?>
 <?=$this->inlineScript(\Zend\View\Helper\HeadScript::SCRIPT, $script, 'SET'); ?>
-<? $this->headScript()
+<?php $this->headScript()
     ->appendFile("vendor/datatables/jquery.dataTables.min.js"); ?>
-<? $this->headScript()
+<?php $this->headScript()
     ->appendFile("vendor/datatables/dataTables.bootstrap.min.js"); ?>
 <!-- finc: admin - i18n - home - END -->
 
diff --git a/themes/finc/templates/error/RuntimeException.phtml b/themes/finc/templates/error/RuntimeException.phtml
index 949ab27f13e..bbafe06af26 100644
--- a/themes/finc/templates/error/RuntimeException.phtml
+++ b/themes/finc/templates/error/RuntimeException.phtml
@@ -1,5 +1,5 @@
 <!-- finc: RuntimeException -->
-<?/* largely copied from /bootstrap3/templates/error/index.phtml #17035 - RL */?>
+<?php /* largely copied from /bootstrap3/templates/error/index.phtml #17035 - RL */?>
 <?php
   // Set page title.
   $this->headTitle($this->translate('An error has occurred'));
diff --git a/themes/finc/templates/error/TimeoutException.phtml b/themes/finc/templates/error/TimeoutException.phtml
index 70da72eacaf..d2f8a14686b 100644
--- a/themes/finc/templates/error/TimeoutException.phtml
+++ b/themes/finc/templates/error/TimeoutException.phtml
@@ -1,5 +1,5 @@
 <!-- finc: TimeoutException -->
-<?/* largely copied from /bootstrap3/templates/error/index.phtml #17035 - RL */?>
+<?php /* largely copied from /bootstrap3/templates/error/index.phtml #17035 - RL */?>
 <?php
   // Set page title.
   $this->headTitle($this->translate('An error has occurred'));
-- 
GitLab