From c1fa5950024c4b161d5af0e60c0e76b418605a68 Mon Sep 17 00:00:00 2001
From: Robert Lange <robert.lange@uni-leipzig.de>
Date: Thu, 3 Nov 2022 10:03:04 +0100
Subject: [PATCH] refs #22080 [finc] remove deprecated / unused methods
* git branch --list *release* | tr -d \* | tr -d '+'| xargs git grep 'getUDKs' | grep -v function
* git branch --list *release* | tr -d \* | tr -d '+'| xargs git grep 'getSeriesWithVolume' | grep -v function
---
.../src/finc/RecordDriver/SolrMarcFinc.php | 7 ---
.../finc/RecordDriver/SolrMarcFincTrait.php | 62 -------------------
2 files changed, 69 deletions(-)
diff --git a/module/finc/src/finc/RecordDriver/SolrMarcFinc.php b/module/finc/src/finc/RecordDriver/SolrMarcFinc.php
index d9e2976d91d..e619a542201 100644
--- a/module/finc/src/finc/RecordDriver/SolrMarcFinc.php
+++ b/module/finc/src/finc/RecordDriver/SolrMarcFinc.php
@@ -42,13 +42,6 @@ class SolrMarcFinc extends SolrMarc
{
use SolrMarcFincTrait;
- /**
- * pattern to identify bsz
- *
- * @deprecated After k10plus transition maybe not longer in use.
- */
- const BSZ_PATTERN = '/^(\(DE-576\))(\d+)(\w|)/';
-
/**
* pattern to identify kxp
*/
diff --git a/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php b/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php
index eb642793a38..a941ed662b4 100644
--- a/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php
+++ b/module/finc/src/finc/RecordDriver/SolrMarcFincTrait.php
@@ -1359,68 +1359,6 @@ trait SolrMarcFincTrait
return false;
}
- /**
- * Get a short list of series for ISBD citation style
- *
- * @return array
- * @link http://www.loc.gov/marc/bibliographic/bd830.html
- */
- protected function getSeriesWithVolume()
- {
- return $this->getFieldArray('830', ['a', 'v'], false);
- }
-
- /**
- * Get local classification of UDK.
- *
- * @return array
- * @deprecated Seems to be only for HTWK in use formerly?
- */
- protected function getUDKs()
- {
- $array = [];
- if (null != $this->getLocalMarcFieldOfLibrary()) {
- $udk = $this->getMarcRecord()->getFields(
- $this->getLocalMarcFieldOfLibrary()
- );
- // if not return void value
- if (!$udk) {
- return $array;
- } // end if
-
- foreach ($udk as $key => $line) {
- // if subfield with udk exists
- if ($line->getSubfield('f')) {
- // get udk
- $array[$key]['index'] = $line->getSubfield('f')->getData();
- // get udk notation
- // fixes by update of File_MARC to version 0.8.0
- // @link https://intern.finc.info/issues/2068
- /*
- if ($notation = $line->getSubfield('n')) {
- // get first value
- $array[$key]['notation'][] = $notation->getData();
- // iteration over udk notation
- while ($record = $notation->next()) {
- $array[$key]['notation'][] = $record->getData();
- $notation = $record;
- }
- } // end if subfield n
- unset($notation);
- */
- if ($record = $line->getSubfields('n')) {
- // iteration over rvk notation
- foreach ($record as $field) {
- $array[$key]['notation'][] = $field->getData();
- }
- } // end if subfield n
- } // end if subfield f
- } // end foreach
- }
- //error_log(print_r($array, true));
- return $array;
- }
-
/**
* Get addional entries for personal names.
*
--
GitLab