From c17c4f969d1ab88e075bff21348c4e51aac39015 Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Wed, 27 May 2020 13:21:24 -0400
Subject: [PATCH] Eliminate quoted boolean in Innovative.ini. (#1628)

---
 config/vufind/Innovative.ini                       | 2 +-
 module/VuFind/src/VuFind/ILS/Driver/Innovative.php | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/config/vufind/Innovative.ini b/config/vufind/Innovative.ini
index 88dcc77b30b..624aaab922c 100644
--- a/config/vufind/Innovative.ini
+++ b/config/vufind/Innovative.ini
@@ -15,7 +15,7 @@ status_due         = "DUE "
 [PATRONAPI]
 ; Enable III Patron API usage for patron authentication
 ; and profile information.
-enabled = "true"
+enabled = true
 url = http://catalog.library.myuniversity.edu:4500/PATRONAPI/
 
 ; Do not change unless you have changed your indexing routine to
diff --git a/module/VuFind/src/VuFind/ILS/Driver/Innovative.php b/module/VuFind/src/VuFind/ILS/Driver/Innovative.php
index 4bf2da95e80..016c9f9035d 100644
--- a/module/VuFind/src/VuFind/ILS/Driver/Innovative.php
+++ b/module/VuFind/src/VuFind/ILS/Driver/Innovative.php
@@ -360,7 +360,8 @@ class Innovative extends AbstractBase implements
     public function patronLogin($username, $password)
     {
         // TODO: if username is a barcode, test to make sure it fits proper format
-        if ($this->config['PATRONAPI']['enabled'] == 'true') {
+        $enabled = $this->config['PATRONAPI']['enabled'] ?? false;
+        if ($enabled && strtolower($enabled) !== 'false') {
             // use patronAPI to authenticate customer
             $url = $this->config['PATRONAPI']['url'];
 
-- 
GitLab