From b9929178bf9462c5bb2ca89d455b133ba6f67bef Mon Sep 17 00:00:00 2001
From: Robert Lange <robert.lange@uni-leipzig.de>
Date: Wed, 28 Apr 2021 10:36:11 +0200
Subject: [PATCH] refs #19431 [finc, BARF] add autocomplete for password input
 in login template

* overwrite bootstrap version of login fields
** loginfields for MultiILS
** loginFields for catalogue login
** add autofocus to username
---
 .../Auth/AbstractBase/loginfields.phtml       | 11 ++++++++++
 .../templates/Auth/MultiILS/loginfields.phtml | 20 +++++++++++++++++++
 .../templates/myresearch/cataloglogin.phtml   |  2 +-
 3 files changed, 32 insertions(+), 1 deletion(-)
 create mode 100644 themes/finc-accessibility/templates/Auth/AbstractBase/loginfields.phtml
 create mode 100644 themes/finc-accessibility/templates/Auth/MultiILS/loginfields.phtml

diff --git a/themes/finc-accessibility/templates/Auth/AbstractBase/loginfields.phtml b/themes/finc-accessibility/templates/Auth/AbstractBase/loginfields.phtml
new file mode 100644
index 00000000000..7a1c5dc4252
--- /dev/null
+++ b/themes/finc-accessibility/templates/Auth/AbstractBase/loginfields.phtml
@@ -0,0 +1,11 @@
+<!-- finc-accessibility: auth - abstractbase - loginfields.phtml -->
+<?php /* copied /themes/bootstrap3/templates/myresearch/loginfields.phtml to add autocomplete */ ?>
+<div class="form-group">
+  <label class="control-label" for="login_<?=$this->escapeHtmlAttr($topClass)?>_username"><?=$this->transEsc('Username')?>:</label>
+  <input type="text" name="username" id="login_<?=$this->escapeHtmlAttr($topClass)?>_username" value="<?=$this->escapeHtmlAttr($this->request->get('username'))?>" class="form-control" autofocus/>
+</div>
+<div class="form-group">
+  <label class="control-label" for="login_<?=$this->escapeHtmlAttr($topClass)?>_password"><?=$this->transEsc('Password')?>:</label>
+  <input type="password" name="password" id="login_<?=$this->escapeHtmlAttr($topClass)?>_password" class="form-control" autocomplete="current-password"/>
+</div>
+<!-- finc-accessibility: auth - abstractbase - loginfields.phtml - END -->
diff --git a/themes/finc-accessibility/templates/Auth/MultiILS/loginfields.phtml b/themes/finc-accessibility/templates/Auth/MultiILS/loginfields.phtml
new file mode 100644
index 00000000000..f0c00fede06
--- /dev/null
+++ b/themes/finc-accessibility/templates/Auth/MultiILS/loginfields.phtml
@@ -0,0 +1,20 @@
+<!-- finc-accessibility: auth - multiils - loginfields.phtml -->
+<?php /* copied from /themes/bootstrap3/templates/Auth/MultiILS/loginfields.phtml to add autocomplete */ ?>
+<div class="form-group">
+  <label class="control-label" for="login_target"><?=$this->transEsc('login_target')?>:</label>
+    <?php $currentTarget = $this->request->get('target'); if (!$currentTarget) $currentTarget = $this->auth()->getManager()->getDefaultLoginTarget();?>
+  <select id="login_target" name="target" class="form-control">
+      <?php foreach ($this->auth()->getManager()->getLoginTargets() as $target):?>
+        <option value="<?=$this->escapeHtmlAttr($target)?>"<?=($target == $currentTarget ? ' selected="selected"' : '')?>><?=$this->transEsc("source_$target", null, $target)?></option>
+      <?php endforeach ?>
+  </select>
+</div>
+<div class="form-group">
+  <label class="control-label" for="login_<?=$this->escapeHtmlAttr($topClass)?>_username"><?=$this->transEsc('Username')?>:</label>
+  <input id="login_<?=$this->escapeHtmlAttr($topClass)?>_username" type="text" name="username" value="<?=$this->escapeHtmlAttr($this->request->get('username'))?>" class="form-control" autofocus/>
+</div>
+<div class="form-group">
+  <label class="control-label" for="login_<?=$this->escapeHtmlAttr($topClass)?>_password"><?=$this->transEsc('Password')?>:</label>
+  <input id="login_<?=$this->escapeHtmlAttr($topClass)?>_password" type="password" name="password" class="form-control" autocomplete="current-password"/>
+</div>
+<!-- finc-accessibility: auth - multiils - loginfields.phtml - END -->
\ No newline at end of file
diff --git a/themes/finc/templates/myresearch/cataloglogin.phtml b/themes/finc/templates/myresearch/cataloglogin.phtml
index 840cb970a2e..f5d936fb60e 100644
--- a/themes/finc/templates/myresearch/cataloglogin.phtml
+++ b/themes/finc/templates/myresearch/cataloglogin.phtml
@@ -34,7 +34,7 @@
     </div>
     <div class="form-group">
       <label class="control-label" for="profile_cat_password"><?=$this->transEsc('Library Catalog Password')?>:</label>
-      <input id="profile_cat_password" type="password" name="cat_password" value="" class="form-control"/>
+      <input id="profile_cat_password" type="password" name="cat_password" value="" class="form-control" autocomplete="current-password"/>
     </div>
     <div class="form-group">
       <input class="btn btn-primary" type="submit" name="processLogin" value="<?=$this->transEsc('Login')?>">
-- 
GitLab