From b856354242ed6faf506475841ededfa15706f790 Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Fri, 18 Jan 2013 10:53:00 -0500
Subject: [PATCH] Fixed bug: "from" date could be set higher than max. Style
fixes.
---
themes/blueprint/js/pubdate_slider.js | 50 +++++++++++++++------------
1 file changed, 27 insertions(+), 23 deletions(-)
diff --git a/themes/blueprint/js/pubdate_slider.js b/themes/blueprint/js/pubdate_slider.js
index 0f2eebf7575..04df18a9eb4 100644
--- a/themes/blueprint/js/pubdate_slider.js
+++ b/themes/blueprint/js/pubdate_slider.js
@@ -1,27 +1,7 @@
-function makePublishDateSlider(prefix) {
- // create the slider widget
- $('#' + prefix + 'Slider').slider({
- range: true,
- min: 0, max: 9999, values: [0, 9999],
- slide: function(event, ui) {
- $('#' + prefix + 'from').val(ui.values[0]);
- $('#' + prefix + 'to').val(ui.values[1]);
- }
- });
- // initialize the slider with the original values
- // in the text boxes
- updatePublishDateSlider(prefix);
-
- // when user enters values into the boxes
- // the slider needs to be updated too
- $('#' + prefix + 'from, #' + prefix + 'to').change(function(){
- updatePublishDateSlider(prefix);
- });
-}
-
function updatePublishDateSlider(prefix) {
- var from = parseInt($('#' + prefix + 'from').val());
- var to = parseInt($('#' + prefix + 'to').val());
+ var from = parseInt($('#' + prefix + 'from').val(), 10);
+ var to = parseInt($('#' + prefix + 'to').val(), 10);
+
// assuming our oldest item is published in the 15th century
var min = 1500;
if (!from || from < min) {
@@ -36,12 +16,36 @@ function updatePublishDateSlider(prefix) {
if (!to || to > max) {
to = max;
}
+ if (from > max) {
+ from = max;
+ }
// update the slider with the new min/max/values
$('#' + prefix + 'Slider').slider('option', {
min: min, max: max, values: [from, to]
});
}
+function makePublishDateSlider(prefix) {
+ // create the slider widget
+ $('#' + prefix + 'Slider').slider({
+ range: true,
+ min: 0, max: 9999, values: [0, 9999],
+ slide: function(event, ui) {
+ $('#' + prefix + 'from').val(ui.values[0]);
+ $('#' + prefix + 'to').val(ui.values[1]);
+ }
+ });
+ // initialize the slider with the original values
+ // in the text boxes
+ updatePublishDateSlider(prefix);
+
+ // when user enters values into the boxes
+ // the slider needs to be updated too
+ $('#' + prefix + 'from, #' + prefix + 'to').change(function(){
+ updatePublishDateSlider(prefix);
+ });
+}
+
$(document).ready(function(){
// create the slider for the publish date facet
$('.dateSlider').each(function(i) {
--
GitLab