From b4be3ce762f48eb19534d7d6a13a0edeabbc4ea9 Mon Sep 17 00:00:00 2001
From: Robert Lange <robert.lange@uni-leipzig.de>
Date: Wed, 26 Aug 2020 13:17:05 +0200
Subject: [PATCH] refs #18212 [finc] remove html-hack for displaying icons as
fallback for cover introduced in 17752
* use fallback cover specified in finc again, noCover2.gif
* remove object tag and render $cover like before
---
local/config/vufind/config.ini | 2 +-
themes/finc/templates/RecordDriver/DefaultRecord/core.phtml | 4 +---
themes/finc/templates/RecordDriver/SolrAI/core.phtml | 4 +---
themes/finc/templates/RecordDriver/SolrMarc/core.phtml | 4 +---
4 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/local/config/vufind/config.ini b/local/config/vufind/config.ini
index 7f6c0d7c9ea..2656d4f0842 100644
--- a/local/config/vufind/config.ini
+++ b/local/config/vufind/config.ini
@@ -635,7 +635,7 @@ coverimagesCache = true
; Otherwise, you can use noCoverAvailableImage to specify a
; path relative to the base of your theme directory for a static image to display.
-noCoverAvailableImage = images/noCoverEmpty.gif
+noCoverAvailableImage = images/noCover2.gif
; You can select from Syndetics, SyndeticsPlus, Amazon Editorial, Amazon, Booksite
; and/or the Guardian
diff --git a/themes/finc/templates/RecordDriver/DefaultRecord/core.phtml b/themes/finc/templates/RecordDriver/DefaultRecord/core.phtml
index dc3020e57e1..3995af48729 100644
--- a/themes/finc/templates/RecordDriver/DefaultRecord/core.phtml
+++ b/themes/finc/templates/RecordDriver/DefaultRecord/core.phtml
@@ -12,9 +12,7 @@
<div class="media-left <?= $this->escapeHtmlAttr($coverDetails['size']) ?> img-col">
<?php /* Display thumbnail if appropriate: */ ?>
<?php if ($cover): ?>
- <object type="image/jpeg" data="<?=$coverDetails['link']?>">
- <?= $this->record($this->driver)->getRecordIcon() ?>
- </object>
+ <?=$cover?>
<?php endif; ?>
<?php /* Display qrcode if appropriate: */ ?>
diff --git a/themes/finc/templates/RecordDriver/SolrAI/core.phtml b/themes/finc/templates/RecordDriver/SolrAI/core.phtml
index 1ca3a8236e4..5fef8c989e6 100644
--- a/themes/finc/templates/RecordDriver/SolrAI/core.phtml
+++ b/themes/finc/templates/RecordDriver/SolrAI/core.phtml
@@ -13,9 +13,7 @@
<div class="media-left <?= $this->escapeHtmlAttr($coverDetails['size']) ?> img-col">
<?php /* Display thumbnail if appropriate: */ ?>
<?php if ($cover): ?>
- <object type="image/jpeg" data="<?=$coverDetails['link']?>">
- <?= $this->record($this->driver)->getRecordIcon() ?>
- </object>
+ <?=$cover?>
<?php endif; ?>
<?php /* Display qrcode if appropriate: */ ?>
diff --git a/themes/finc/templates/RecordDriver/SolrMarc/core.phtml b/themes/finc/templates/RecordDriver/SolrMarc/core.phtml
index 21d74fbc3a3..a6906906c05 100644
--- a/themes/finc/templates/RecordDriver/SolrMarc/core.phtml
+++ b/themes/finc/templates/RecordDriver/SolrMarc/core.phtml
@@ -13,9 +13,7 @@
<div class="media-left <?=$this->escapeHtmlAttr($coverDetails['size'])?> img-col">
<?php /* Display thumbnail if appropriate: */ ?>
<?php if ($cover): ?>
- <object type="image/jpeg" data="<?=$coverDetails['link']?>">
- <?= $this->record($this->driver)->getRecordIcon() ?>
- </object>
+ <?=$cover?>
<?php endif; ?>
<?php /* Display qrcode if appropriate: */ ?>
--
GitLab