From af9e8814f61de56d4653454ecdfef40d6984cefc Mon Sep 17 00:00:00 2001 From: Robert Lange <robert.lange@uni-leipzig.de> Date: Tue, 28 Jul 2020 14:33:10 +0200 Subject: [PATCH] refs #18108 [master] fix for finc testing of PAIA * repair outdated option test in PAIATest testgetOptionsNotOnlyFirstButAll --- .../tests/unit-tests/src/fincTest/ILS/Driver/PAIATest.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/module/finc/tests/unit-tests/src/fincTest/ILS/Driver/PAIATest.php b/module/finc/tests/unit-tests/src/fincTest/ILS/Driver/PAIATest.php index 392a0b27049..8169a7e9ad0 100644 --- a/module/finc/tests/unit-tests/src/fincTest/ILS/Driver/PAIATest.php +++ b/module/finc/tests/unit-tests/src/fincTest/ILS/Driver/PAIATest.php @@ -75,8 +75,6 @@ class PAIAFincTest extends \VuFindTest\ILS\Driver\PAIATest ] ]; - - /** * Test * @@ -101,7 +99,6 @@ class PAIAFincTest extends \VuFindTest\ILS\Driver\PAIATest ] ]; - $conditions = [ self::$pickupCondition ]; @@ -474,7 +471,6 @@ class PAIAFincTest extends \VuFindTest\ILS\Driver\PAIATest ); } - /** * Test * @@ -520,6 +516,8 @@ class PAIAFincTest extends \VuFindTest\ILS\Driver\PAIATest "Wrong option value" ); + $validOptions[0][0] = 'TESTID1'; + $validOptions[0][1] = 'TESTID2'; $this->assertEquals( ['TESTID1', 'TESTID2'], $conn->getOptions(self::$pickupCondition, $options, false, $validOptions), @@ -533,7 +531,7 @@ class PAIAFincTest extends \VuFindTest\ILS\Driver\PAIATest $this->assertEquals( ['TESTLABEL1', 'TESTID2'], - $conn->getOptions(self::$pickupCondition, $options, false, $validOptions), + $conn->getOptions(self::$pickupCondition, $options, false, null), "Wrong option value" ); } -- GitLab