From a0e882f1ae8aeab51639b28a4bd59ce7fc08ec0e Mon Sep 17 00:00:00 2001 From: Samuel Henrique <samueloph@gmail.com> Date: Wed, 3 Aug 2016 08:54:28 -0300 Subject: [PATCH] solr.sh shellcheck tweaks (#770) - Just some minor changes to avoid parameter expansion; I know that they are very unlikelly considering the script will run on specific conditions, but I think it's better to explicitly avoid this situation. --- solr.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/solr.sh b/solr.sh index 5b9233ba803..2a4956dc0db 100755 --- a/solr.sh +++ b/solr.sh @@ -36,7 +36,7 @@ usage() # Set VUFIND_HOME if [ -z "$VUFIND_HOME" ] then - VUFIND_HOME=`dirname $0` + VUFIND_HOME=$(dirname "$0") fi if [ -z "$SOLR_HOME" ] @@ -65,4 +65,4 @@ then fi export SOLR_LOGS_DIR=$SOLR_LOGS_DIR -$SOLR_BIN/solr $1 -p $SOLR_PORT -s $SOLR_HOME -m $SOLR_HEAP -a "-Dsolr.log=$SOLR_LOGS_DIR" +"$SOLR_BIN/solr" "$1" -p "$SOLR_PORT" -s "$SOLR_HOME" -m "$SOLR_HEAP" -a "-Dsolr.log=$SOLR_LOGS_DIR" -- GitLab