From 9d22235cb53c619adfbeacb415d042c7080d6c40 Mon Sep 17 00:00:00 2001
From: Frank Morgner <morgnerf@ub.uni-leipzig.de>
Date: Fri, 16 Feb 2018 12:25:56 +0100
Subject: [PATCH] refs #12318 * return false instead of logically correct null
to avoid throwing exception in subsequential core methods
---
module/finc/src/finc/ILS/Driver/FincILS.php | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/module/finc/src/finc/ILS/Driver/FincILS.php b/module/finc/src/finc/ILS/Driver/FincILS.php
index 98225885485..3ab786cc25c 100644
--- a/module/finc/src/finc/ILS/Driver/FincILS.php
+++ b/module/finc/src/finc/ILS/Driver/FincILS.php
@@ -1530,8 +1530,10 @@ class FincILS extends PAIA implements LoggerAwareInterface
return current($result->getRecords())->getUniqueId();
} catch (\Exception $e) {
$this->debug($e);
- // refs #12318 return null if no main identifier can delivered
- return null;
+ // refs #12318 return falls if no main identifier can delivered
+ // null will logically correct but throws exceptions in
+ // subsequential core methods
+ return false;
}
}
// todo: check if return $ilsId is reasonable in context.
--
GitLab