From 9bdb55d5a0c0ae74f7544adb32a82cdc7c52cf52 Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Mon, 11 Nov 2013 11:42:56 -0500
Subject: [PATCH] Eliminated unused variables.
---
module/VuFind/src/VuFind/Recommend/EuropeanaResults.php | 2 +-
module/VuFind/src/VuFind/Search/Base/Options.php | 1 -
module/VuFind/src/VuFind/Search/Solr/Params.php | 2 +-
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/module/VuFind/src/VuFind/Recommend/EuropeanaResults.php b/module/VuFind/src/VuFind/Recommend/EuropeanaResults.php
index 0e57dcdf4ab..bbe8d472256 100644
--- a/module/VuFind/src/VuFind/Recommend/EuropeanaResults.php
+++ b/module/VuFind/src/VuFind/Recommend/EuropeanaResults.php
@@ -283,7 +283,7 @@ class EuropeanaResults implements RecommendInterface,
}
$parsedFeed = FeedReader::import($this->targetUrl);
$resultsProcessed = array();
- foreach ($parsedFeed as $key => $value) {
+ foreach ($parsedFeed as $value) {
$link = (string)$value->link;
if (!empty($link)) {
$resultsProcessed[] = array(
diff --git a/module/VuFind/src/VuFind/Search/Base/Options.php b/module/VuFind/src/VuFind/Search/Base/Options.php
index 59e60766eaf..100119408ee 100644
--- a/module/VuFind/src/VuFind/Search/Base/Options.php
+++ b/module/VuFind/src/VuFind/Search/Base/Options.php
@@ -172,7 +172,6 @@ abstract class Options implements TranslatorAwareInterface
{
$label = empty($label) ? false : $this->translate($label);
- $targetHandler = false;
foreach ($this->getBasicHandlers() as $id => $currentLabel) {
if ($this->translate($currentLabel) == $label) {
return $id;
diff --git a/module/VuFind/src/VuFind/Search/Solr/Params.php b/module/VuFind/src/VuFind/Search/Solr/Params.php
index d5e7f89097b..4454b808943 100644
--- a/module/VuFind/src/VuFind/Search/Solr/Params.php
+++ b/module/VuFind/src/VuFind/Search/Solr/Params.php
@@ -136,7 +136,7 @@ class Params extends \VuFind\Search\Base\Params
$facetSet = array();
if (!empty($this->facetConfig)) {
$facetSet['limit'] = $this->facetLimit;
- foreach ($this->facetConfig as $facetField => $facetName) {
+ foreach (array_keys($this->facetConfig) as $facetField) {
if ($this->getFacetOperator($facetField) == 'OR') {
$facetField = '{!ex=' . $facetField . '_filter}' . $facetField;
}
--
GitLab