From 9b13c57ac17086b881dac794d0d6df0403dbf81d Mon Sep 17 00:00:00 2001
From: Viola Elsenhans <elsenhans@ub.uni-leipzig.de>
Date: Tue, 26 Sep 2023 11:50:38 +0200
Subject: [PATCH] refs #19697 [finc] fix syntax errors
---
local/languages/de.ini | 1 +
local/languages/en.ini | 1 +
.../templates/RecordDriver/SolrDico/data-license.phtml | 3 ++-
themes/finc/templates/RecordTab/collectionlist.phtml | 5 +++--
themes/finc/templates/myresearch/acquisition.phtml | 10 +++++-----
5 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/local/languages/de.ini b/local/languages/de.ini
index 19ccf522784..010e598d1e0 100644
--- a/local/languages/de.ini
+++ b/local/languages/de.ini
@@ -2027,6 +2027,7 @@ skip-to = "Zu"
Search type = "Suchtyp"
License = "Lizenz"
+LicenseIcon = "Lizenz Icon"
fine_date_short = "Gebühr fällig"
diff --git a/local/languages/en.ini b/local/languages/en.ini
index cd1d79d9ad7..9b45a6c57f7 100644
--- a/local/languages/en.ini
+++ b/local/languages/en.ini
@@ -2120,6 +2120,7 @@ skip-to = "Skip to "
Skip to facet = "Skip to your selected search filter '%%filter_name%%'"
License = "License"
+LicenseIcon = "License icon"
fine_date_short = "Fine Date"
diff --git a/themes/finc/templates/RecordDriver/SolrDico/data-license.phtml b/themes/finc/templates/RecordDriver/SolrDico/data-license.phtml
index ed4bbae530e..43009e3464f 100644
--- a/themes/finc/templates/RecordDriver/SolrDico/data-license.phtml
+++ b/themes/finc/templates/RecordDriver/SolrDico/data-license.phtml
@@ -4,7 +4,8 @@
<?php ob_start() ?>
<?=$label ?>
<?php if (isset($data['icon'])): ?>
- <img class="collection-data collection-licence-image" src="<?=$data['icon']?>"/>
+ <?php /* finc: add alt-Tag #19697 */ ?>
+ <img class="collection-data collection-licence-image" src="<?=$data['icon']?>" alt="<?=$this->transEsc('LicenseIcon')?>"/>
<?php endif; ?>
<?php $label = ob_get_contents();
ob_end_clean();
diff --git a/themes/finc/templates/RecordTab/collectionlist.phtml b/themes/finc/templates/RecordTab/collectionlist.phtml
index b44ba7c72df..94cc9f912fa 100644
--- a/themes/finc/templates/RecordTab/collectionlist.phtml
+++ b/themes/finc/templates/RecordTab/collectionlist.phtml
@@ -96,11 +96,12 @@
<?php endif; ?>
*/?>
</div>
- <form class="form-inline" method="post" name="bulkActionForm" action="<?=$this->url('cart-searchresultsbulk')?>">
+ <?php /* de_15: do NOT render search/list-list into the <form>-element, it is causing W3C errors #19697 */ ?>
+ <?php /* <form class="form-inline" method="post" name="bulkActionForm" action="<?=$this->url('cart-searchresultsbulk')?>"> */ ?>
<?=$this->context($this)->renderInContext('search/bulk-action-buttons.phtml', $searchDetails + ['idPrefix' => ''])?>
<?=$this->render('search/list-' . $results->getParams()->getView() . '.phtml', $searchDetails)?>
<?=$this->paginationControl($results->getPaginator(), 'Sliding', 'search/pagination.phtml', ['results' => $results])?>
- </form>
+ <?php /* </form> */ ?>
<?php else: ?>
<?php /* finc: change h4 to h3 */ ?>
<h3><?=$this->transEsc($params->getDisplayQuery() || ($filterCount ?? 0) > 0 ? 'nohit_heading' : 'collection_empty')?></h3>
diff --git a/themes/finc/templates/myresearch/acquisition.phtml b/themes/finc/templates/myresearch/acquisition.phtml
index 3c541783a3c..00c846d3b8b 100644
--- a/themes/finc/templates/myresearch/acquisition.phtml
+++ b/themes/finc/templates/myresearch/acquisition.phtml
@@ -14,7 +14,7 @@ $this->layout()->breadcrumbs = '<li><a href="' . $this->url('myresearch-home') .
<h1><?=$this->transEsc('PDA::pda_form_subtitle')?></h1>
<?=$this->flashmessages()?>
- <form method="post" action="" name="acquisitionForm">
+ <form method="post" name="acquisitionForm">
<h3><?=$this->transEsc('PDA::pda_form_suggestions_limit')?></h3>
<div class="form-group">
@@ -30,13 +30,13 @@ $this->layout()->breadcrumbs = '<li><a href="' . $this->url('myresearch-home') .
</div>
<div class="form-group">
- <label class="control-label" for="acquistion_reasons"><?=$this->transEsc('PDA::pda_form_statement_label')?><span class="required">*</span></label>
- <textarea id="acquisition_reasons" type="text" cols="50" rows="5" name="reasons" class="form-control"><?=(isset($acquisitionStatement) && !empty($acquisitionStatement)) ? $acquisitionStatement : ''?></textarea>
+ <label class="control-label" for="acquisition_reasons"><?=$this->transEsc('PDA::pda_form_statement_label')?><span class="required">*</span></label>
+ <textarea id="acquisition_reasons" cols="50" rows="5" name="reasons" class="form-control"><?=(isset($acquisitionStatement) && !empty($acquisitionStatement)) ? $acquisitionStatement : ''?></textarea>
</div>
<div class="form-group">
- <label class="control-label" for="acquistion_proposal"><?=$this->transEsc('PDA::pda_form_proposal_label')?><span class="required">*</span></label>
- <textarea id="acquisition_proposal" class="form-control" type="text" cols="50" rows="5" name="proposal"><?=(isset($acquisitionProposal) && !empty($acquisitionProposal)) ? $acquisitionProposal : ''?></textarea>
+ <label class="control-label" for="acquisition_proposal"><?=$this->transEsc('PDA::pda_form_proposal_label')?><span class="required">*</span></label>
+ <textarea id="acquisition_proposal" class="form-control" cols="50" rows="5" name="proposal"><?=(isset($acquisitionProposal) && !empty($acquisitionProposal)) ? $acquisitionProposal : ''?></textarea>
</div>
<div class="form-group">
--
GitLab