From 9950b26cad800a0b20df582c3b2efabbb23844e6 Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Mon, 8 Jun 2015 10:39:09 -0400
Subject: [PATCH] Removed redundant isset() checks.
---
themes/blueprint/templates/ajax/resolverLinks.phtml | 6 +++---
themes/bootstrap3/templates/ajax/resolverLinks.phtml | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/themes/blueprint/templates/ajax/resolverLinks.phtml b/themes/blueprint/templates/ajax/resolverLinks.phtml
index 45e4b8176ae..eb33b010ec6 100644
--- a/themes/blueprint/templates/ajax/resolverLinks.phtml
+++ b/themes/blueprint/templates/ajax/resolverLinks.phtml
@@ -5,7 +5,7 @@
<ul>
<? foreach ($this->electronic as $link): ?>
<li>
- <? if (isset($link['href']) && !empty($link['href'])): ?>
+ <? if (!empty($link['href'])): ?>
<a href="<?=$this->escapeHtmlAttr($link['href'])?>" title="<?=isset($link['service_type'])?$this->escapeHtmlAttr($link['service_type']):''?>"><?=isset($link['title'])?$this->escapeHtml($link['title']):''?></a> <?=isset($link['coverage'])?$this->escapeHtml($link['coverage']):''?>
<? else: ?>
<?=isset($link['title'])?$this->escapeHtml($link['title']):''?> <?=isset($link['coverage'])?$this->escapeHtml($link['coverage']):''?>
@@ -21,7 +21,7 @@
<ul>
<? foreach ($this->print as $link): ?>
<li>
- <? if (isset($link['href']) && !empty($link['href'])): ?>
+ <? if (!empty($link['href'])): ?>
<a href="<?=$this->escapeHtmlAttr($link['href'])?>" title="<?=isset($link['service_type'])?$this->escapeHtmlAttr($link['service_type']):''?>"><?=isset($link['title'])?$this->escapeHtml($link['title']):''?></a> <?=isset($link['coverage'])?$this->escapeHtml($link['coverage']):''?>
<? else: ?>
<?=isset($link['title'])?$this->escapeHtml($link['title']):''?> <?=isset($link['coverage'])?$this->escapeHtml($link['coverage']):''?>
@@ -36,7 +36,7 @@
<? if (!empty($this->services)): ?>
<ul>
<? foreach ($this->services as $link): ?>
- <? if (isset($link['href']) && !empty($link['href'])): ?>
+ <? if (!empty($link['href'])): ?>
<li>
<a href="<?=$this->escapeHtmlAttr($link['href'])?>" title="<?=isset($link['service_type'])?$this->escapeHtmlAttr($link['service_type']):''?>"><?=isset($link['title'])?$this->escapeHtml($link['title']):''?></a>
</li>
diff --git a/themes/bootstrap3/templates/ajax/resolverLinks.phtml b/themes/bootstrap3/templates/ajax/resolverLinks.phtml
index 45e4b8176ae..eb33b010ec6 100644
--- a/themes/bootstrap3/templates/ajax/resolverLinks.phtml
+++ b/themes/bootstrap3/templates/ajax/resolverLinks.phtml
@@ -5,7 +5,7 @@
<ul>
<? foreach ($this->electronic as $link): ?>
<li>
- <? if (isset($link['href']) && !empty($link['href'])): ?>
+ <? if (!empty($link['href'])): ?>
<a href="<?=$this->escapeHtmlAttr($link['href'])?>" title="<?=isset($link['service_type'])?$this->escapeHtmlAttr($link['service_type']):''?>"><?=isset($link['title'])?$this->escapeHtml($link['title']):''?></a> <?=isset($link['coverage'])?$this->escapeHtml($link['coverage']):''?>
<? else: ?>
<?=isset($link['title'])?$this->escapeHtml($link['title']):''?> <?=isset($link['coverage'])?$this->escapeHtml($link['coverage']):''?>
@@ -21,7 +21,7 @@
<ul>
<? foreach ($this->print as $link): ?>
<li>
- <? if (isset($link['href']) && !empty($link['href'])): ?>
+ <? if (!empty($link['href'])): ?>
<a href="<?=$this->escapeHtmlAttr($link['href'])?>" title="<?=isset($link['service_type'])?$this->escapeHtmlAttr($link['service_type']):''?>"><?=isset($link['title'])?$this->escapeHtml($link['title']):''?></a> <?=isset($link['coverage'])?$this->escapeHtml($link['coverage']):''?>
<? else: ?>
<?=isset($link['title'])?$this->escapeHtml($link['title']):''?> <?=isset($link['coverage'])?$this->escapeHtml($link['coverage']):''?>
@@ -36,7 +36,7 @@
<? if (!empty($this->services)): ?>
<ul>
<? foreach ($this->services as $link): ?>
- <? if (isset($link['href']) && !empty($link['href'])): ?>
+ <? if (!empty($link['href'])): ?>
<li>
<a href="<?=$this->escapeHtmlAttr($link['href'])?>" title="<?=isset($link['service_type'])?$this->escapeHtmlAttr($link['service_type']):''?>"><?=isset($link['title'])?$this->escapeHtml($link['title']):''?></a>
</li>
--
GitLab