From 8e91b33c86a1e2a84967ac0c62528f2944f4934f Mon Sep 17 00:00:00 2001 From: Demian Katz <demian.katz@villanova.edu> Date: Thu, 11 Sep 2014 13:53:30 -0400 Subject: [PATCH] Don't bother measuring code coverage of factories -- they're just glue. --- module/VuDL/src/VuDL/Factory.php | 1 + module/VuFind/src/VuFind/Auth/Factory.php | 1 + module/VuFind/src/VuFind/Autocomplete/Factory.php | 1 + module/VuFind/src/VuFind/Content/AuthorNotes/Factory.php | 1 + module/VuFind/src/VuFind/Content/Covers/Factory.php | 1 + module/VuFind/src/VuFind/Content/Excerpts/Factory.php | 1 + module/VuFind/src/VuFind/Content/Factory.php | 1 + module/VuFind/src/VuFind/Content/Reviews/Factory.php | 1 + module/VuFind/src/VuFind/Controller/Factory.php | 1 + module/VuFind/src/VuFind/Controller/Plugin/Factory.php | 1 + module/VuFind/src/VuFind/Db/Table/Factory.php | 1 + module/VuFind/src/VuFind/Hierarchy/Driver/Factory.php | 1 + module/VuFind/src/VuFind/Hierarchy/TreeDataSource/Factory.php | 1 + module/VuFind/src/VuFind/ILS/Driver/Factory.php | 1 + module/VuFind/src/VuFind/Mailer/Factory.php | 1 + module/VuFind/src/VuFind/Recommend/Factory.php | 1 + module/VuFind/src/VuFind/RecordDriver/Factory.php | 1 + module/VuFind/src/VuFind/RecordTab/Factory.php | 2 ++ module/VuFind/src/VuFind/Related/Factory.php | 1 + module/VuFind/src/VuFind/Resolver/Driver/Factory.php | 1 + module/VuFind/src/VuFind/SMS/Factory.php | 1 + module/VuFind/src/VuFind/Search/Options/Factory.php | 1 + module/VuFind/src/VuFind/Search/Results/Factory.php | 1 + module/VuFind/src/VuFind/Service/Factory.php | 1 + module/VuFind/src/VuFind/Statistics/Driver/Factory.php | 1 + module/VuFind/src/VuFind/View/Helper/Blueprint/Factory.php | 1 + module/VuFind/src/VuFind/View/Helper/Bootprint/Factory.php | 1 + module/VuFind/src/VuFind/View/Helper/Bootstrap/Factory.php | 1 + module/VuFind/src/VuFind/View/Helper/Bootstrap3/Factory.php | 1 + module/VuFind/src/VuFind/View/Helper/Root/Factory.php | 1 + module/VuFindTheme/src/VuFindTheme/View/Helper/Factory.php | 1 + 31 files changed, 32 insertions(+) diff --git a/module/VuDL/src/VuDL/Factory.php b/module/VuDL/src/VuDL/Factory.php index 8f534e6d863..33b4ea11076 100644 --- a/module/VuDL/src/VuDL/Factory.php +++ b/module/VuDL/src/VuDL/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Auth/Factory.php b/module/VuFind/src/VuFind/Auth/Factory.php index 56fc9a37318..295cc3ff57b 100644 --- a/module/VuFind/src/VuFind/Auth/Factory.php +++ b/module/VuFind/src/VuFind/Auth/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Autocomplete/Factory.php b/module/VuFind/src/VuFind/Autocomplete/Factory.php index d84ec4080bf..8d3de323584 100644 --- a/module/VuFind/src/VuFind/Autocomplete/Factory.php +++ b/module/VuFind/src/VuFind/Autocomplete/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Content/AuthorNotes/Factory.php b/module/VuFind/src/VuFind/Content/AuthorNotes/Factory.php index 4b61bba1ec6..236ae8ff060 100644 --- a/module/VuFind/src/VuFind/Content/AuthorNotes/Factory.php +++ b/module/VuFind/src/VuFind/Content/AuthorNotes/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Content/Covers/Factory.php b/module/VuFind/src/VuFind/Content/Covers/Factory.php index a33b33bc99e..1ca954db4a1 100644 --- a/module/VuFind/src/VuFind/Content/Covers/Factory.php +++ b/module/VuFind/src/VuFind/Content/Covers/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Content/Excerpts/Factory.php b/module/VuFind/src/VuFind/Content/Excerpts/Factory.php index 96155ceb630..a9c41df368e 100644 --- a/module/VuFind/src/VuFind/Content/Excerpts/Factory.php +++ b/module/VuFind/src/VuFind/Content/Excerpts/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Content/Factory.php b/module/VuFind/src/VuFind/Content/Factory.php index 1bd59b49604..48876ca7f59 100644 --- a/module/VuFind/src/VuFind/Content/Factory.php +++ b/module/VuFind/src/VuFind/Content/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Content/Reviews/Factory.php b/module/VuFind/src/VuFind/Content/Reviews/Factory.php index 8708f3ed659..a59c71045c9 100644 --- a/module/VuFind/src/VuFind/Content/Reviews/Factory.php +++ b/module/VuFind/src/VuFind/Content/Reviews/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Controller/Factory.php b/module/VuFind/src/VuFind/Controller/Factory.php index 9b3ac34b798..0cf4bbc41b5 100644 --- a/module/VuFind/src/VuFind/Controller/Factory.php +++ b/module/VuFind/src/VuFind/Controller/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Controller/Plugin/Factory.php b/module/VuFind/src/VuFind/Controller/Plugin/Factory.php index 242fa8f1fb6..376573e89f9 100644 --- a/module/VuFind/src/VuFind/Controller/Plugin/Factory.php +++ b/module/VuFind/src/VuFind/Controller/Plugin/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Db/Table/Factory.php b/module/VuFind/src/VuFind/Db/Table/Factory.php index 4e6c9bf4b47..bc308970714 100644 --- a/module/VuFind/src/VuFind/Db/Table/Factory.php +++ b/module/VuFind/src/VuFind/Db/Table/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Hierarchy/Driver/Factory.php b/module/VuFind/src/VuFind/Hierarchy/Driver/Factory.php index c964c0334ae..bc7b29f78b1 100644 --- a/module/VuFind/src/VuFind/Hierarchy/Driver/Factory.php +++ b/module/VuFind/src/VuFind/Hierarchy/Driver/Factory.php @@ -38,6 +38,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:hierarchy_components Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Hierarchy/TreeDataSource/Factory.php b/module/VuFind/src/VuFind/Hierarchy/TreeDataSource/Factory.php index adb078dd7a7..234ea10388a 100644 --- a/module/VuFind/src/VuFind/Hierarchy/TreeDataSource/Factory.php +++ b/module/VuFind/src/VuFind/Hierarchy/TreeDataSource/Factory.php @@ -38,6 +38,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:hierarchy_components Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/ILS/Driver/Factory.php b/module/VuFind/src/VuFind/ILS/Driver/Factory.php index ae7f20e9fd1..19145d3e272 100644 --- a/module/VuFind/src/VuFind/ILS/Driver/Factory.php +++ b/module/VuFind/src/VuFind/ILS/Driver/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:hierarchy_components Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Mailer/Factory.php b/module/VuFind/src/VuFind/Mailer/Factory.php index 369efe95ad7..479994d3e28 100644 --- a/module/VuFind/src/VuFind/Mailer/Factory.php +++ b/module/VuFind/src/VuFind/Mailer/Factory.php @@ -37,6 +37,7 @@ use Zend\Mail\Transport\Smtp, Zend\Mail\Transport\SmtpOptions, * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory implements \Zend\ServiceManager\FactoryInterface { diff --git a/module/VuFind/src/VuFind/Recommend/Factory.php b/module/VuFind/src/VuFind/Recommend/Factory.php index 12f04061064..538f18441ae 100644 --- a/module/VuFind/src/VuFind/Recommend/Factory.php +++ b/module/VuFind/src/VuFind/Recommend/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:hierarchy_components Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/RecordDriver/Factory.php b/module/VuFind/src/VuFind/RecordDriver/Factory.php index f799f8b8ac2..cb8900e653a 100644 --- a/module/VuFind/src/VuFind/RecordDriver/Factory.php +++ b/module/VuFind/src/VuFind/RecordDriver/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:hierarchy_components Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/RecordTab/Factory.php b/module/VuFind/src/VuFind/RecordTab/Factory.php index b48e57cb2e5..bcab56ee4b1 100644 --- a/module/VuFind/src/VuFind/RecordTab/Factory.php +++ b/module/VuFind/src/VuFind/RecordTab/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:hierarchy_components Wiki + * @codeCoverageIgnore */ class Factory { @@ -100,6 +101,7 @@ class Factory */ protected static function getHideSetting(\Zend\Config\Config $config, $tab) { + // TODO: can we move this code out of the factory so it's more easily reused? $setting = isset($config->Content->hide_if_empty) ? $config->Content->hide_if_empty : false; if ($setting === true || $setting === false diff --git a/module/VuFind/src/VuFind/Related/Factory.php b/module/VuFind/src/VuFind/Related/Factory.php index 99c7998a0c9..f8af30e36ec 100644 --- a/module/VuFind/src/VuFind/Related/Factory.php +++ b/module/VuFind/src/VuFind/Related/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:hierarchy_components Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Resolver/Driver/Factory.php b/module/VuFind/src/VuFind/Resolver/Driver/Factory.php index 30c06be1df0..ede51b3e204 100644 --- a/module/VuFind/src/VuFind/Resolver/Driver/Factory.php +++ b/module/VuFind/src/VuFind/Resolver/Driver/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:hierarchy_components Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/SMS/Factory.php b/module/VuFind/src/VuFind/SMS/Factory.php index d255136bf0f..4c1bc67e17b 100644 --- a/module/VuFind/src/VuFind/SMS/Factory.php +++ b/module/VuFind/src/VuFind/SMS/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceLocatorInterface; * @author Ronan McHugh <vufind-tech@lists.sourceforge.net> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory implements \Zend\ServiceManager\FactoryInterface { diff --git a/module/VuFind/src/VuFind/Search/Options/Factory.php b/module/VuFind/src/VuFind/Search/Options/Factory.php index a3b2ef84caa..f94ab30cf0d 100644 --- a/module/VuFind/src/VuFind/Search/Options/Factory.php +++ b/module/VuFind/src/VuFind/Search/Options/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:hierarchy_components Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Search/Results/Factory.php b/module/VuFind/src/VuFind/Search/Results/Factory.php index 2f9d9a620cf..f2b0ef68220 100644 --- a/module/VuFind/src/VuFind/Search/Results/Factory.php +++ b/module/VuFind/src/VuFind/Search/Results/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:hierarchy_components Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Service/Factory.php b/module/VuFind/src/VuFind/Service/Factory.php index d21a0a64d16..77aa9f71ce6 100644 --- a/module/VuFind/src/VuFind/Service/Factory.php +++ b/module/VuFind/src/VuFind/Service/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/Statistics/Driver/Factory.php b/module/VuFind/src/VuFind/Statistics/Driver/Factory.php index dbf76f244d7..7ca7c5f145b 100644 --- a/module/VuFind/src/VuFind/Statistics/Driver/Factory.php +++ b/module/VuFind/src/VuFind/Statistics/Driver/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:hierarchy_components Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/View/Helper/Blueprint/Factory.php b/module/VuFind/src/VuFind/View/Helper/Blueprint/Factory.php index 9b47daa8e73..bf17596eafe 100644 --- a/module/VuFind/src/VuFind/View/Helper/Blueprint/Factory.php +++ b/module/VuFind/src/VuFind/View/Helper/Blueprint/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/View/Helper/Bootprint/Factory.php b/module/VuFind/src/VuFind/View/Helper/Bootprint/Factory.php index 73a2e20c708..519e636144b 100644 --- a/module/VuFind/src/VuFind/View/Helper/Bootprint/Factory.php +++ b/module/VuFind/src/VuFind/View/Helper/Bootprint/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/View/Helper/Bootstrap/Factory.php b/module/VuFind/src/VuFind/View/Helper/Bootstrap/Factory.php index f4b76d87f15..12a4bc07c03 100644 --- a/module/VuFind/src/VuFind/View/Helper/Bootstrap/Factory.php +++ b/module/VuFind/src/VuFind/View/Helper/Bootstrap/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/View/Helper/Bootstrap3/Factory.php b/module/VuFind/src/VuFind/View/Helper/Bootstrap3/Factory.php index 00e85cd4509..828c42d9bf2 100644 --- a/module/VuFind/src/VuFind/View/Helper/Bootstrap3/Factory.php +++ b/module/VuFind/src/VuFind/View/Helper/Bootstrap3/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFind/src/VuFind/View/Helper/Root/Factory.php b/module/VuFind/src/VuFind/View/Helper/Root/Factory.php index d1ace6957df..3a2ef704d70 100644 --- a/module/VuFind/src/VuFind/View/Helper/Root/Factory.php +++ b/module/VuFind/src/VuFind/View/Helper/Root/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { diff --git a/module/VuFindTheme/src/VuFindTheme/View/Helper/Factory.php b/module/VuFindTheme/src/VuFindTheme/View/Helper/Factory.php index bd57084a048..bf39b62bdca 100644 --- a/module/VuFindTheme/src/VuFindTheme/View/Helper/Factory.php +++ b/module/VuFindTheme/src/VuFindTheme/View/Helper/Factory.php @@ -36,6 +36,7 @@ use Zend\ServiceManager\ServiceManager; * @author Demian Katz <demian.katz@villanova.edu> * @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License * @link http://vufind.org/wiki/vufind2:developer_manual Wiki + * @codeCoverageIgnore */ class Factory { -- GitLab