From 7fd66147f439327ea206df4ff917ed6c1f95c2dd Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Fri, 1 Nov 2013 13:43:33 -0400
Subject: [PATCH] More PHPMD cleanup.
---
module/VuFind/src/VuFind/Auth/AbstractBase.php | 2 ++
module/VuFind/src/VuFind/SMS/AbstractBase.php | 1 +
.../src/VuFind/ServiceManager/AbstractPluginFactory.php | 2 ++
module/VuFind/src/VuFind/Statistics/Driver/AbstractBase.php | 2 ++
.../src/VuFindConsole/Mvc/Router/ConsoleRouter.php | 5 +++++
module/VuFindLocalTemplate/Module.php | 2 ++
6 files changed, 14 insertions(+)
diff --git a/module/VuFind/src/VuFind/Auth/AbstractBase.php b/module/VuFind/src/VuFind/Auth/AbstractBase.php
index df31681fab2..125ff8c2d4f 100644
--- a/module/VuFind/src/VuFind/Auth/AbstractBase.php
+++ b/module/VuFind/src/VuFind/Auth/AbstractBase.php
@@ -135,6 +135,7 @@ abstract class AbstractBase implements \VuFind\Db\Table\DbTableAwareInterface
*
* @throws AuthException
* @return \VuFind\Db\Row\User New user row.
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function create($request)
{
@@ -151,6 +152,7 @@ abstract class AbstractBase implements \VuFind\Db\Table\DbTableAwareInterface
* send user to after login (some drivers may override this).
*
* @return bool|string
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getSessionInitiator($target)
{
diff --git a/module/VuFind/src/VuFind/SMS/AbstractBase.php b/module/VuFind/src/VuFind/SMS/AbstractBase.php
index 373b74949a6..1cbbb27bf28 100644
--- a/module/VuFind/src/VuFind/SMS/AbstractBase.php
+++ b/module/VuFind/src/VuFind/SMS/AbstractBase.php
@@ -50,6 +50,7 @@ abstract class AbstractBase implements SMSInterface
*
* @param \Zend\Config\Config $config SMS configuration
* @param array $options Additional options
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function __construct(\Zend\Config\Config $config, $options = array())
{
diff --git a/module/VuFind/src/VuFind/ServiceManager/AbstractPluginFactory.php b/module/VuFind/src/VuFind/ServiceManager/AbstractPluginFactory.php
index 016d49ef798..70daa2d168f 100644
--- a/module/VuFind/src/VuFind/ServiceManager/AbstractPluginFactory.php
+++ b/module/VuFind/src/VuFind/ServiceManager/AbstractPluginFactory.php
@@ -85,6 +85,7 @@ abstract class AbstractPluginFactory implements AbstractFactoryInterface
* @param string $requestedName Unfiltered name of service
*
* @return bool
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function canCreateServiceWithName(ServiceLocatorInterface $serviceLocator,
$name, $requestedName
@@ -101,6 +102,7 @@ abstract class AbstractPluginFactory implements AbstractFactoryInterface
* @param string $requestedName Unfiltered name of service
*
* @return object
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function createServiceWithName(ServiceLocatorInterface $serviceLocator,
$name, $requestedName
diff --git a/module/VuFind/src/VuFind/Statistics/Driver/AbstractBase.php b/module/VuFind/src/VuFind/Statistics/Driver/AbstractBase.php
index 10734c36e0c..251c5b563f0 100644
--- a/module/VuFind/src/VuFind/Statistics/Driver/AbstractBase.php
+++ b/module/VuFind/src/VuFind/Statistics/Driver/AbstractBase.php
@@ -79,6 +79,7 @@ abstract class AbstractBase
* @param array $value Extra options for search. Value => match this value
*
* @return array
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getFullList($field, $value = array())
{
@@ -93,6 +94,7 @@ abstract class AbstractBase
* @param integer $limit How many items to return
*
* @return array
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getBrowserStats($version, $limit)
{
diff --git a/module/VuFindConsole/src/VuFindConsole/Mvc/Router/ConsoleRouter.php b/module/VuFindConsole/src/VuFindConsole/Mvc/Router/ConsoleRouter.php
index fbd12ee35e0..de8b6eb3ec7 100644
--- a/module/VuFindConsole/src/VuFindConsole/Mvc/Router/ConsoleRouter.php
+++ b/module/VuFindConsole/src/VuFindConsole/Mvc/Router/ConsoleRouter.php
@@ -107,6 +107,7 @@ class ConsoleRouter implements RouteStackInterface
* @param array $options Route options
*
* @return mixed
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function assemble(array $params = array(), array $options = array())
{
@@ -121,6 +122,7 @@ class ConsoleRouter implements RouteStackInterface
* @param integer $priority Priority
*
* @return RouteStackInterface
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function addRoute($name, $route, $priority = null)
{
@@ -133,6 +135,7 @@ class ConsoleRouter implements RouteStackInterface
* @param array|\Traversable $routes Routes to add
*
* @return RouteStackInterface
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function addRoutes($routes)
{
@@ -145,6 +148,7 @@ class ConsoleRouter implements RouteStackInterface
* @param string $name Route name
*
* @return RouteStackInterface
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function removeRoute($name)
{
@@ -157,6 +161,7 @@ class ConsoleRouter implements RouteStackInterface
* @param array|\Traversable $routes Routes to set
*
* @return RouteStackInterface
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function setRoutes($routes)
{
diff --git a/module/VuFindLocalTemplate/Module.php b/module/VuFindLocalTemplate/Module.php
index f01c4c7982e..171fc98cdca 100644
--- a/module/VuFindLocalTemplate/Module.php
+++ b/module/VuFindLocalTemplate/Module.php
@@ -72,6 +72,7 @@ class Module
* @param ModuleManager $m Module manager
*
* @return void
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function init(ModuleManager $m)
{
@@ -83,6 +84,7 @@ class Module
* @param MvcEvent $e Event
*
* @return void
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function onBootstrap(MvcEvent $e)
{
--
GitLab