From 6da72d4d40aa6f4c420483b39294ee20b873786e Mon Sep 17 00:00:00 2001
From: Dorian Merz <merz@ub.uni-leipzig.de>
Date: Fri, 22 Nov 2019 10:59:12 +0100
Subject: [PATCH] refs #16433 [fid_bbi] bugfixes in detail view for SolrDefault
records
* remove seemingly duplicate holdings tab
* fix bug in publicationDetails template
---
module/fid_bbi/config/module.config.php | 1 +
.../DefaultRecord/data-publicationDetails.phtml | 7 +++++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/module/fid_bbi/config/module.config.php b/module/fid_bbi/config/module.config.php
index 7568e10a435..6f02bff9c41 100644
--- a/module/fid_bbi/config/module.config.php
+++ b/module/fid_bbi/config/module.config.php
@@ -70,6 +70,7 @@ $config = [
'tabs' => [
'Description' => 'Description',
'Worldcat' => 'Worldcat',
+ 'Holdings' => null,
'TOC' => 'TOC',
'UserComments' => 'UserComments',
'Reviews' => 'Reviews',
diff --git a/themes/fid_bbi/templates/RecordDriver/DefaultRecord/data-publicationDetails.phtml b/themes/fid_bbi/templates/RecordDriver/DefaultRecord/data-publicationDetails.phtml
index 89b17f0c066..bb12e7c2d49 100644
--- a/themes/fid_bbi/templates/RecordDriver/DefaultRecord/data-publicationDetails.phtml
+++ b/themes/fid_bbi/templates/RecordDriver/DefaultRecord/data-publicationDetails.phtml
@@ -1,7 +1,10 @@
<!-- fid_bbi: RecordDriver - solrDefault - data-publicationDetails -->
<? if (!empty($data)): ?>
<div itemscope itemtype="http://schema.org/publisher">
- <? foreach ($data as $field): ?>
+ <? foreach ((array)$data as $field): ?>
+ <?php if(is_string($data)): ?>
+ <?=$this->escapeHtml($data)?>
+ <?php else: ?>
<span property="publisher" typeof="Organization">
<? $pubPlace = $field->getPlace(); if (!empty($pubPlace)): ?>
<span property="location" typeof="Place">
@@ -20,7 +23,7 @@
<? /*else: ?>
<?=$this->escapeHtml($pubDateSort)*/?></span>
<? endif; ?>
- </span><br/>
+ </span><?php endif; ?><br/>
<? endforeach; ?>
</div>
<? endif ?>
--
GitLab