From 636b79102751254526055f8094b5f99951b8a666 Mon Sep 17 00:00:00 2001
From: Dorian Merz <merz@ub.uni-leipzig.de>
Date: Thu, 18 Feb 2021 09:17:33 +0100
Subject: [PATCH] refs #18775 [fid_bbi] optimize performance
* avoid rendering of sub-template if unnecessary
---
themes/fid_bbi/templates/search/advanced-search-info.phtml | 5 ++---
themes/fid_bbi/templates/search/results.phtml | 5 +++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/themes/fid_bbi/templates/search/advanced-search-info.phtml b/themes/fid_bbi/templates/search/advanced-search-info.phtml
index a021b153178..bdfe5acbb98 100644
--- a/themes/fid_bbi/templates/search/advanced-search-info.phtml
+++ b/themes/fid_bbi/templates/search/advanced-search-info.phtml
@@ -1,7 +1,7 @@
<!-- fid_bbi - templates - search - advanced-search-info -->
<?php
// Following section adaption from themes/finc/templates/search/results.phtml
-$searchType = $this->params->getSearchType();
+
$searchId = $this->results->getSearchId();
$searchClassId = $this->params->getSearchClassId();
$lookfor = $this->results->getUrlQuery()->isQuerySuppressed() ? '' : $this->params->getDisplayQuery();
@@ -18,7 +18,6 @@ $options = $this->searchOptions($this->searchClassId);
$advSearch = $options->getAdvancedSearchAction();
?>
-<?php if ($searchType == 'advanced'): ?>
<div class="results_advanced-search-info">
<?=$this->icon('small/magnifier')?>
@@ -35,5 +34,5 @@ $advSearch = $options->getAdvancedSearchAction();
</a>
</p>
</div>
-<?php endif; ?>
+
<!-- fid_bbi - templates - search - advanced-search-info - END -->
diff --git a/themes/fid_bbi/templates/search/results.phtml b/themes/fid_bbi/templates/search/results.phtml
index 17aa1814e78..d765ab96a22 100644
--- a/themes/fid_bbi/templates/search/results.phtml
+++ b/themes/fid_bbi/templates/search/results.phtml
@@ -64,8 +64,9 @@ $this->headScript()->appendFile("check_save_statuses.js");
<?=$this->flashmessages()?>
<div class="results_header">
- <?=$this->render('search/advanced-search-info.phtml');?>
-
+ <?php if ($this->params->getSearchType() === 'advanced'):?>
+ <?=$this->render('search/advanced-search-info.phtml');?>
+ <?php endif; ?>
<div class="results_count">
<?=$this->translate('%%count%% results', ['%%count%%' => $this->localizedNumber($recordTotal)])?>
</div>
--
GitLab