diff --git a/module/VuFind/src/VuFind/I18n/Translator/Loader/ExtendedIni.php b/module/VuFind/src/VuFind/I18n/Translator/Loader/ExtendedIni.php
index 592880ac1844f9f9b0050c19ef41f8fca7acbb35..e969af4be29ce24dad52e9053069e5bc66a926c7 100644
--- a/module/VuFind/src/VuFind/I18n/Translator/Loader/ExtendedIni.php
+++ b/module/VuFind/src/VuFind/I18n/Translator/Loader/ExtendedIni.php
@@ -56,6 +56,7 @@ class ExtendedIni implements FileLoaderInterface
*
* @return TextDomain
* @throws InvalidArgumentException
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function load($locale, $filename)
{
diff --git a/module/VuFind/src/VuFind/ILS/Connection.php b/module/VuFind/src/VuFind/ILS/Connection.php
index 96da4ec1b07b3b73a32fd8bcfe5def5d33d7a46c..7a5f659667b8426926697b4983a623b51dc9b501 100644
--- a/module/VuFind/src/VuFind/ILS/Connection.php
+++ b/module/VuFind/src/VuFind/ILS/Connection.php
@@ -269,6 +269,7 @@ class Connection
* @return mixed On success, an associative array with specific function keys
* and values either for cancelling holds via a form or a URL;
* on failure, false.
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
protected function checkMethodcancelHolds($functionConfig)
{
@@ -298,6 +299,7 @@ class Connection
*
* @return mixed On success, an associative array with specific function keys
* and values either for renewing items via a form or a URL; on failure, false.
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
protected function checkMethodRenewals($functionConfig)
{
diff --git a/module/VuFind/src/VuFind/ILS/Driver/Amicus.php b/module/VuFind/src/VuFind/ILS/Driver/Amicus.php
index 4f57728f37ad68b3bf92ae85b16d702eafe136b8..9301c0fd682ffb67cf83a1f18f43921f948251a9 100644
--- a/module/VuFind/src/VuFind/ILS/Driver/Amicus.php
+++ b/module/VuFind/src/VuFind/ILS/Driver/Amicus.php
@@ -765,6 +765,7 @@ class Amicus extends AbstractBase implements TranslatorAwareInterface
* @param array $details Item details from getHoldings return array
*
* @return string URL to ILS's OPAC's place hold screen.
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getHoldLink($recordId, $details)
{
@@ -788,6 +789,7 @@ class Amicus extends AbstractBase implements TranslatorAwareInterface
*
* @throws ILSException
* @return array Associative array with 'count' and 'results' keys
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getNewItems($page, $limit, $daysOld, $fundId = null)
{
@@ -880,6 +882,7 @@ class Amicus extends AbstractBase implements TranslatorAwareInterface
*
* @throws ILSException
* @return array An array of associative arrays representing reserve items.
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function findReserves($course, $inst, $dept)
{
diff --git a/module/VuFind/src/VuFind/ILS/Driver/ClaviusSQL.php b/module/VuFind/src/VuFind/ILS/Driver/ClaviusSQL.php
index f2cdecf064533cf78b81b92c90653795fe1efe66..0a6ab946a047314c6dcdd8f0be8ed4d7b2845dc2 100644
--- a/module/VuFind/src/VuFind/ILS/Driver/ClaviusSQL.php
+++ b/module/VuFind/src/VuFind/ILS/Driver/ClaviusSQL.php
@@ -380,18 +380,18 @@ class ClaviusSQL extends AbstractBase
}
/**
- * Get Hold Link
- *
- * The goal for this method is to return a URL to a "place hold" web page on
- * the ILS OPAC. This is used for ILSs that do not support an API or method
- * to place Holds.
- *
- * @param string $id The id of the bib record
- * @param array $details Item details from getHoldings return array
- *
- * @return string URL to ILS's OPAC's place hold screen.
- */
-
+ * Get Hold Link
+ *
+ * The goal for this method is to return a URL to a "place hold" web page on
+ * the ILS OPAC. This is used for ILSs that do not support an API or method
+ * to place Holds.
+ *
+ * @param string $id The id of the bib record
+ * @param array $details Item details from getHoldings return array
+ *
+ * @return string URL to ILS's OPAC's place hold screen.
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+ */
public function getHoldLink($id, $details)
{
// Web link of the ILS for placing hold on the item
@@ -467,6 +467,7 @@ class ClaviusSQL extends AbstractBase
*
* @return array An array of associative arrays with locationID and
* locationDisplay keys
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getPickUpLocations($patron = false, $holdDetails = null)
{
@@ -808,6 +809,7 @@ class ClaviusSQL extends AbstractBase
* <li>item_id - this is used to match up renew responses and must match
* the item_id in the renew response</li>
* </ul>
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getMyTransactions($user, $history = false)
{
diff --git a/module/VuFind/src/VuFind/ILS/Driver/Evergreen.php b/module/VuFind/src/VuFind/ILS/Driver/Evergreen.php
index 274bceaab5df4f40457b46c3444afc8963617b3f..b4a148146bc1d77a2097cee3995cacc9f0547eaf 100644
--- a/module/VuFind/src/VuFind/ILS/Driver/Evergreen.php
+++ b/module/VuFind/src/VuFind/ILS/Driver/Evergreen.php
@@ -624,6 +624,7 @@ HERE;
*
* @throws ILSException
* @return array Associative array with 'count' and 'results' keys
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getNewItems($page, $limit, $daysOld, $fundId = null)
{
diff --git a/module/VuFind/src/VuFind/ILS/Driver/Horizon.php b/module/VuFind/src/VuFind/ILS/Driver/Horizon.php
index 1c3ea1665643fe62dc14ddafe0ebea1fd20e1fe7..239fe3956e43a6059b648785f07c29188c19d4a3 100644
--- a/module/VuFind/src/VuFind/ILS/Driver/Horizon.php
+++ b/module/VuFind/src/VuFind/ILS/Driver/Horizon.php
@@ -270,6 +270,7 @@ class Horizon extends AbstractBase
* @param array $patron Patron Array
*
* @return array Keyed data
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
protected function processHoldingRow($id, $row, $patron)
{
@@ -991,6 +992,7 @@ class Horizon extends AbstractBase
* does not use acquisitions.
*
* @return array Associative array with 'count' and 'results' keys
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getNewItems($page, $limit, $daysOld, $fundId = null)
{
@@ -998,7 +1000,7 @@ class Horizon extends AbstractBase
$hzVersionRequired = "7.4.0.0";
if ($this->checkHzVersion($hzVersionRequired)) {
- // Set the Sybase or MSSQL rowcount limit
+ // Set the Sybase or MSSQL rowcount limit (TODO: account for $page)
$limitsql = "set rowcount {$limit}";
// This is the actual query for IDs.
diff --git a/module/VuFind/src/VuFind/ILS/Driver/HorizonXMLAPI.php b/module/VuFind/src/VuFind/ILS/Driver/HorizonXMLAPI.php
index 58ce2b8d58bcf42576b6bf69b0b9d641f90a45fa..67a5b34e4a8fa66dd0d724c29237fe1573a03eff 100644
--- a/module/VuFind/src/VuFind/ILS/Driver/HorizonXMLAPI.php
+++ b/module/VuFind/src/VuFind/ILS/Driver/HorizonXMLAPI.php
@@ -190,6 +190,7 @@ class HorizonXMLAPI extends Horizon implements \VuFindHttp\HttpServiceAwareInter
* @throws ILSException
* @return array An array of associative arrays with locationID and
* locationDisplay keys
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getPickUpLocations($patron, $holdDetails = null)
{
@@ -267,6 +268,7 @@ class HorizonXMLAPI extends Horizon implements \VuFindHttp\HttpServiceAwareInter
* or may be ignored.
*
* @return string The default pickup location for the patron.
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getDefaultPickUpLocation($patron = false, $holdDetails = null)
{
diff --git a/module/VuFind/src/VuFind/ILS/Driver/Innovative.php b/module/VuFind/src/VuFind/ILS/Driver/Innovative.php
index 6ee68144d3b405c7801f7268c15ebab9fc3ea9d5..4476c1e52f717ccdf91b6cf44e42e113a480ef15 100644
--- a/module/VuFind/src/VuFind/ILS/Driver/Innovative.php
+++ b/module/VuFind/src/VuFind/ILS/Driver/Innovative.php
@@ -326,6 +326,7 @@ class Innovative extends AbstractBase implements
* @param array $details Item details from getHoldings return array
*
* @return string URL to ILS's OPAC's place hold screen.
+ * @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function getHoldLink($id, $details)
{