From 58c9910d4d01dc0ebd11dd06831a1bebb1401040 Mon Sep 17 00:00:00 2001 From: Sebastian Kehr <kehr@ub.uni-leipzig.de> Date: Wed, 12 Feb 2020 15:42:18 +0100 Subject: [PATCH] refs #16853 [master-v5] drop custom code quality configuration --- composer.local.0.finc.json | 1 - tests/finc/.php_cs | 15 --------------- tests/finc/phpcs.xml | 15 --------------- 3 files changed, 31 deletions(-) delete mode 100644 tests/finc/.php_cs delete mode 100644 tests/finc/phpcs.xml diff --git a/composer.local.0.finc.json b/composer.local.0.finc.json index 92cc3f7bbfa..87f48624f59 100644 --- a/composer.local.0.finc.json +++ b/composer.local.0.finc.json @@ -10,7 +10,6 @@ "scripts": { "post-install-cmd": ["@copy-themes-force", "@dump-modules"], "post-update-cmd": ["@copy-themes-force", "@dump-modules"], - "phpcs-finc": "vendor/bin/phpcs --standard=tests/finc/phpcs.xml", "copy-themes-force": "php devops/composer/themes.php --force", "dump-modules": "ComposerEventHandlers\\Modules::dump" }, diff --git a/tests/finc/.php_cs b/tests/finc/.php_cs deleted file mode 100644 index 2c82e17e1cf..00000000000 --- a/tests/finc/.php_cs +++ /dev/null @@ -1,15 +0,0 @@ -<?php - -$baseDir = realpath(__DIR__ . '/../../'); -$finder = PhpCsFixer\Finder::create()->in("$baseDir/module/finc/src"); -$cacheDir = "$baseDir/data/cache/.php_cs_cache"; - -if (!is_dir($cacheDir)) { - mkdir($cacheDir); -} - -return PhpCsFixer\Config::create() - ->setCacheFile("$cacheDir/.code.cache") - ->setRiskyAllowed(true) - ->setRules(['@PSR2' => true]) - ->setFinder($finder); diff --git a/tests/finc/phpcs.xml b/tests/finc/phpcs.xml deleted file mode 100644 index 59d7e42200f..00000000000 --- a/tests/finc/phpcs.xml +++ /dev/null @@ -1,15 +0,0 @@ -<?xml version="1.0"?> -<ruleset name="finc cs ruleset" namespace="finc\PHPCS"> - <description>finc coding standards.</description> - <file>../../module/finc/src/</file> - <arg name="extensions" value="php"/> - <rule ref="PSR2" /> - <rule ref="PEAR.Commenting.ClassComment" /> - <rule ref="PEAR.Commenting.FileComment" /> - <rule ref="Squiz.Commenting.FunctionComment.Missing"/> - <rule ref="Squiz.Commenting.FunctionComment.MissingParamTag"/> - <rule ref="Squiz.Commenting.FunctionComment.MissingParamName"/> - <rule ref="Squiz.Commenting.FunctionComment.ParamNameNoMatch"/> - <rule ref="Squiz.Commenting.FunctionComment.IncorrectTypeHint"/> - <rule ref="Squiz.Commenting.FunctionComment.MissingReturn"/> -</ruleset> -- GitLab