From 48e07fde57f83b8b2a6df0c07ab530f0e2ed5eea Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Fri, 25 Apr 2014 14:12:53 -0400
Subject: [PATCH] Eliminated unused variables.
---
module/VuDL/src/VuDL/Connection/AbstractBase.php | 1 -
module/VuFind/src/VuFind/Controller/MyResearchController.php | 2 +-
module/VuFind/src/VuFind/Search/Primo/Params.php | 2 --
.../VuFindSearch/src/VuFindSearch/Backend/Primo/Connector.php | 2 +-
4 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/module/VuDL/src/VuDL/Connection/AbstractBase.php b/module/VuDL/src/VuDL/Connection/AbstractBase.php
index 4ed1d0edbe6..6df8e9641c3 100644
--- a/module/VuDL/src/VuDL/Connection/AbstractBase.php
+++ b/module/VuDL/src/VuDL/Connection/AbstractBase.php
@@ -130,7 +130,6 @@ class AbstractBase implements \VuFindHttp\HttpServiceAwareInterface
{
// Format details
// Get config for which details we want
- $fields = $combinedFields = array(); // Save to combine later
$detailsList = $this->getDetailsList();
if (empty($detailsList)) {
throw new \Exception('Missing [Details] in VuDL.ini');
diff --git a/module/VuFind/src/VuFind/Controller/MyResearchController.php b/module/VuFind/src/VuFind/Controller/MyResearchController.php
index 427e218abcb..92870c04e4b 100644
--- a/module/VuFind/src/VuFind/Controller/MyResearchController.php
+++ b/module/VuFind/src/VuFind/Controller/MyResearchController.php
@@ -1279,7 +1279,7 @@ class MyResearchController extends AbstractBase
// Reassign oldpwd to password in the request so login works
$temp_password = $post->password;
$post->password = $post->oldpwd;
- $authClass = $this->getAuthManager()->login($request);
+ $this->getAuthManager()->login($request);
$post->password = $temp_password;
} catch(AuthException $e) {
$this->flashMessenger()->setNamespace('error')
diff --git a/module/VuFind/src/VuFind/Search/Primo/Params.php b/module/VuFind/src/VuFind/Search/Primo/Params.php
index eeac45fc4e9..4df764392c9 100644
--- a/module/VuFind/src/VuFind/Search/Primo/Params.php
+++ b/module/VuFind/src/VuFind/Search/Primo/Params.php
@@ -48,8 +48,6 @@ class Params extends \VuFind\Search\Base\Params
{
$backendParams = new ParamBag();
- $options = $this->getOptions();
-
// The "relevance" sort option is a VuFind reserved word; we need to make
// this null in order to achieve the desired effect with Summon:
$sort = $this->getSort();
diff --git a/module/VuFindSearch/src/VuFindSearch/Backend/Primo/Connector.php b/module/VuFindSearch/src/VuFindSearch/Backend/Primo/Connector.php
index ab47639ea87..01c318ac4ba 100644
--- a/module/VuFindSearch/src/VuFindSearch/Backend/Primo/Connector.php
+++ b/module/VuFindSearch/src/VuFindSearch/Backend/Primo/Connector.php
@@ -233,7 +233,7 @@ class Connector
$lookfor = "";
if (is_array($terms)) {
- foreach ($terms as $key => $thisTerm) {
+ foreach ($terms as $thisTerm) {
//set the index to search
switch ($thisTerm['index']) {
case "AllFields":
--
GitLab