From 44567a594bef8c0b90a23d6e66426c7bb6f06cd5 Mon Sep 17 00:00:00 2001
From: Dorian Merz <merz@ub.uni-leipzig.de>
Date: Thu, 17 Sep 2020 09:32:05 +0200
Subject: [PATCH] refs #18345 [finc] removes titleDetails template
---
.../Helper/Root/RecordDataFormatterFactory.php | 15 ++++++---------
.../DefaultRecord/data-titleDetails.phtml | 5 +++++
2 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/module/finc/src/finc/View/Helper/Root/RecordDataFormatterFactory.php b/module/finc/src/finc/View/Helper/Root/RecordDataFormatterFactory.php
index a42c9843325..c959eec5b6e 100644
--- a/module/finc/src/finc/View/Helper/Root/RecordDataFormatterFactory.php
+++ b/module/finc/src/finc/View/Helper/Root/RecordDataFormatterFactory.php
@@ -193,10 +193,9 @@ class RecordDataFormatterFactory
]
]
);
- $spec->setTemplateLine(
+ $spec->setLine(
'Title',
- 'getTitleDetails',
- 'data-titleDetails.phtml'
+ 'getTitleDetails'
);
$spec->setTemplateLine(
'Dates of publication',
@@ -362,10 +361,9 @@ class RecordDataFormatterFactory
]
]
);
- $spec->setTemplateLine(
+ $spec->setLine(
'Title',
- 'getTitleDetails',
- 'data-titleDetails.phtml'
+ 'getTitleDetails'
);
$spec->setTemplateLine(
'Title Uniform',
@@ -838,10 +836,9 @@ class RecordDataFormatterFactory
]
]
);
- $spec->setTemplateLine(
+ $spec->setLine(
'Title',
- 'getTitleDetails',
- 'data-titleDetails.phtml'
+ 'getTitleDetails'
);
$spec->setTemplateLine(
'Title Uniform',
diff --git a/themes/finc/templates/RecordDriver/DefaultRecord/data-titleDetails.phtml b/themes/finc/templates/RecordDriver/DefaultRecord/data-titleDetails.phtml
index fd0c9ce8f43..39deaefc949 100644
--- a/themes/finc/templates/RecordDriver/DefaultRecord/data-titleDetails.phtml
+++ b/themes/finc/templates/RecordDriver/DefaultRecord/data-titleDetails.phtml
@@ -1,3 +1,8 @@
+<?php
+/** @deprecated since the else part is never active, this should be substituted by a
+ * simple SpecLine (giving escapeHtml with <br/>) in the RecordDataFormatterFactory
+ */
+?>
<!-- finc: RecordDriver - DefaultRecord - data-titleDetails -->
<?php if (!empty($data)): ?>
<?php $i = 0;
--
GitLab