From 40f6c305a66c099ee7d0fbfd130718a0418c3be3 Mon Sep 17 00:00:00 2001
From: Ere Maijala <ere.maijala@helsinki.fi>
Date: Thu, 21 Nov 2019 16:42:06 +0200
Subject: [PATCH] Alma: Fix date and status display for the holds list. (#1502)
---
module/VuFind/src/VuFind/ILS/Driver/Alma.php | 21 +++++++++++++++++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/module/VuFind/src/VuFind/ILS/Driver/Alma.php b/module/VuFind/src/VuFind/ILS/Driver/Alma.php
index b8228ab810c..6e9f5a4d687 100644
--- a/module/VuFind/src/VuFind/ILS/Driver/Alma.php
+++ b/module/VuFind/src/VuFind/ILS/Driver/Alma.php
@@ -895,11 +895,26 @@ class Alma extends AbstractBase implements \VuFindHttp\HttpServiceAwareInterface
);
$holdList = [];
foreach ($xml as $request) {
+ $lastInterestDate = $request->last_interest_date
+ ? $this->dateConverter->convertToDisplayDate(
+ 'Y-m-dT', (string)$request->last_interest_date
+ ) : null;
+ $available = (string)$request->request_status === 'On Hold Shelf';
+ $lastPickupDate = null;
+ if ($available) {
+ $lastPickupDate = $request->expiry_date
+ ? $this->dateConverter->convertToDisplayDate(
+ 'Y-m-dT', (string)$request->expiry_date
+ ) : null;
+ }
$holdList[] = [
- 'create' => (string)$request->request_date,
- 'expire' => (string)$request->last_interest_date,
+ 'create' => $this->dateConverter->convertToDisplayDate(
+ 'Y-m-dT', (string)$request->request_date
+ ),
+ 'expire' => $lastInterestDate,
'id' => (string)$request->request_id,
- 'in_transit' => (string)$request->request_status !== 'On Hold Shelf',
+ 'available' => $available,
+ 'last_pickup_date' => $lastPickupDate,
'item_id' => (string)$request->mms_id,
'location' => (string)$request->pickup_location,
'processed' => $request->item_policy === 'InterlibraryLoan'
--
GitLab