From 39a87d485e60d3fbddf47c9e67dd70869897291c Mon Sep 17 00:00:00 2001
From: Dorian Merz <merz@ub.uni-leipzig.de>
Date: Fri, 18 Sep 2020 08:09:02 +0200
Subject: [PATCH] refs #18376 [fid_bbi] do not show numbers as labels in the
Tags line
---
.../View/Helper/Root/RecordDataFormatterFactory.php | 12 +++++++++---
.../templates/RecordDriver/DefaultRecord/core.phtml | 2 +-
.../templates/RecordDriver/SolrMarc/core.phtml | 2 +-
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/module/fid_bbi/src/fid_bbi/View/Helper/Root/RecordDataFormatterFactory.php b/module/fid_bbi/src/fid_bbi/View/Helper/Root/RecordDataFormatterFactory.php
index e9de86d03a5..e28e602ed36 100644
--- a/module/fid_bbi/src/fid_bbi/View/Helper/Root/RecordDataFormatterFactory.php
+++ b/module/fid_bbi/src/fid_bbi/View/Helper/Root/RecordDataFormatterFactory.php
@@ -106,7 +106,9 @@ class RecordDataFormatterFactory extends \fid\View\Helper\Root\RecordDataFormatt
$spec->setTemplateLine(
'Related Items', 'getAllRecordLinks', 'data-allRecordLinks.phtml'
);
- $spec->setTemplateLine(1, true, 'data-tags.phtml');
+ $spec->setTemplateLine('Tags', true, 'data-tags.phtml',[
+ 'labelFunction' => function() {return null;}
+ ]);
return $spec->getArray();
}
@@ -332,7 +334,9 @@ class RecordDataFormatterFactory extends \fid\View\Helper\Root\RecordDataFormatt
'useCache' => true
]
);
- $spec->setTemplateLine(2, true, 'data-tags.phtml');
+ $spec->setTemplateLine('Tags', true, 'data-tags.phtml',[
+ 'labelFunction' => function() {return null;}
+ ]);
return $spec->getArray();
}
@@ -442,7 +446,9 @@ class RecordDataFormatterFactory extends \fid\View\Helper\Root\RecordDataFormatt
'Source',
'getMegaCollection'
);
- $spec->setTemplateLine(3, true, 'data-tags.phtml');
+ $spec->setTemplateLine('Tags', true, 'data-tags.phtml',[
+ 'labelFunction' => function() {return null;}
+ ]);
return $spec->getArray();
}
}
diff --git a/themes/fid_bbi/templates/RecordDriver/DefaultRecord/core.phtml b/themes/fid_bbi/templates/RecordDriver/DefaultRecord/core.phtml
index 17cdc4e69a2..6175ce2ce23 100644
--- a/themes/fid_bbi/templates/RecordDriver/DefaultRecord/core.phtml
+++ b/themes/fid_bbi/templates/RecordDriver/DefaultRecord/core.phtml
@@ -64,7 +64,7 @@
<table class="table table-striped">
<caption class="sr-only"><?=$this->transEsc('Bibliographic Details')?></caption>
<?php foreach ($coreFields as $current): ?>
- <?php if (is_numeric($current['label'])): ?>
+ <?php if (is_null($current['label'])): ?>
<?=$current['value']?>
<?php else: ?>
<tr>
diff --git a/themes/fid_bbi/templates/RecordDriver/SolrMarc/core.phtml b/themes/fid_bbi/templates/RecordDriver/SolrMarc/core.phtml
index 79f757058f3..62626dd26df 100644
--- a/themes/fid_bbi/templates/RecordDriver/SolrMarc/core.phtml
+++ b/themes/fid_bbi/templates/RecordDriver/SolrMarc/core.phtml
@@ -63,7 +63,7 @@
<table class="table table-striped">
<caption class="sr-only"><?=$this->transEsc('Bibliographic Details')?></caption>
<?php foreach ($coreFields as $current): ?>
- <?php if (is_numeric($current['label'])): ?>
+ <?php if (is_null($current['label'])): ?>
<?=$current['value']?>
<?php else: ?>
<tr>
--
GitLab