From 322ad4d8d7aad530753a6818310f4acd30df2e8e Mon Sep 17 00:00:00 2001
From: Hajo Seng <hajoseng@sub.uni-hamburg.de>
Date: Wed, 21 Aug 2019 16:23:29 +0200
Subject: [PATCH] population results of myTransactionsMapping with
 getBasicDetails the same way as those of myStorageRetrievalRequestsMapping
 and myHoldsMapping

---
 module/VuFind/src/VuFind/ILS/Driver/PAIA.php | 21 ++------------------
 1 file changed, 2 insertions(+), 19 deletions(-)

diff --git a/module/VuFind/src/VuFind/ILS/Driver/PAIA.php b/module/VuFind/src/VuFind/ILS/Driver/PAIA.php
index 740c58b6d8f..35a7429cd81 100644
--- a/module/VuFind/src/VuFind/ILS/Driver/PAIA.php
+++ b/module/VuFind/src/VuFind/ILS/Driver/PAIA.php
@@ -1551,31 +1551,18 @@ class PAIA extends DAIA
         $results = [];
 
         foreach ($items as $doc) {
-            $result = [];
+            $result = $this->getBasicDetails($doc);
+
             // canrenew (0..1) whether a document can be renewed (bool)
             $result['renewable'] = (isset($doc['canrenew'])
                 && $this->paiaCheckScope(self::SCOPE_WRITE_ITEMS))
                 ? $doc['canrenew'] : false;
 
-            // item (0..1) URI of a particular copy
-            $result['item_id'] = ($doc['item'] ?? '');
-
             $result['renew_details']
                 = (isset($doc['canrenew']) && $doc['canrenew']
                 && $this->paiaCheckScope(self::SCOPE_WRITE_ITEMS))
                 ? $result['item_id'] : '';
 
-            // edition (0..1)  URI of a the document (no particular copy)
-            // hook for retrieving alternative ItemId in case PAIA does not
-            // the needed id
-            $result['id'] = (isset($doc['edition'])
-                ? $this->getAlternativeItemId($doc['edition']) : '');
-
-            // requested (0..1) URI that was originally requested
-
-            // about (0..1) textual description of the document
-            $result['title'] = ($doc['about'] ?? null);
-
             // queue (0..1) number of waiting requests for the document or item
             $result['request'] = ($doc['queue'] ?? null);
 
@@ -1611,10 +1598,6 @@ class PAIA extends DAIA
 
             // storageid (0..1) location URI
 
-            // PAIA custom field
-            // label (0..1) call number, shelf mark or similar item label
-            $result['callnumber'] = $this->getCallNumber($doc);
-
             // Optional VuFind fields
             /*
             $result['barcode'] = null;
-- 
GitLab