From 2a82d7443a9bf129b9dd27e10f99662e6e9f185b Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Fri, 18 Jan 2013 09:33:04 -0500
Subject: [PATCH] Fixed confusing variable naming in "add to cart" closure;
increased efficiency by leaving the function as soon as a duplicate is found.
---
themes/blueprint/js/cart.js | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/themes/blueprint/js/cart.js b/themes/blueprint/js/cart.js
index 59f2ea1d424..578cd15d00c 100644
--- a/themes/blueprint/js/cart.js
+++ b/themes/blueprint/js/cart.js
@@ -1,3 +1,5 @@
+/*global vufindString*/
+
var _CART_COOKIE = 'vufind_cart';
var _CART_COOKIE_SOURCES = 'vufind_cart_src';
var _CART_COOKIE_DELIM = "\t";
@@ -17,9 +19,10 @@ function registerUpdateCart($form) {
var msg = "";
var orig = getItemsFromCartCookie();
$(selected).each(function(i) {
- for (i in orig) {
- if (this == orig[i]) {
+ for (var x in orig) {
+ if (this == orig[x]) {
inCart++;
+ return;
}
}
addItemToCartCookie(this);
--
GitLab