diff --git a/module/VuFind/src/VuFind/ILS/Driver/HorizonXMLAPI.php b/module/VuFind/src/VuFind/ILS/Driver/HorizonXMLAPI.php index de8d2a3e388b767c341d8641ffb4f000553f1272..58ce2b8d58bcf42576b6bf69b0b9d641f90a45fa 100644 --- a/module/VuFind/src/VuFind/ILS/Driver/HorizonXMLAPI.php +++ b/module/VuFind/src/VuFind/ILS/Driver/HorizonXMLAPI.php @@ -650,7 +650,6 @@ class HorizonXMLAPI extends Horizon implements \VuFindHttp\HttpServiceAwareInter $count = 0; // Go through the submited bib ids and look for a match foreach ($data as $values) { - $bibID = $values['bib_id']; $itemID = $values['item_id']; // If the bib id is matched, the cancel must have failed if (in_array($values['bib_id'], $keys)) { @@ -670,7 +669,8 @@ class HorizonXMLAPI extends Horizon implements \VuFindHttp\HttpServiceAwareInter if ($response->error->message) { $message = (string)$response->error->message; } - foreach ($items as $itemID) { + foreach ($data as $values) { + $itemID = $values['item_id']; $responseItems[$itemID] = array( 'success' => false, 'status' => "hold_cancel_fail", @@ -697,7 +697,6 @@ class HorizonXMLAPI extends Horizon implements \VuFindHttp\HttpServiceAwareInter */ public function placeHold($holdDetails) { - $userId = $holdDetails['patron']['id']; $userBarcode = $holdDetails['patron']['id']; $userPassword = $holdDetails['patron']['cat_password']; $bibId = $holdDetails['id']; @@ -838,9 +837,6 @@ class HorizonXMLAPI extends Horizon implements \VuFindHttp\HttpServiceAwareInter public function renewMyItems($renewDetails) { $renewals = $renewDetails['details']; - $patron = $renewDetails['patron']; - $renewals_count = count($renewals); - $userId = $holdDetails['patron']['id']; $userBarcode = $renewDetails['patron']['id']; $userPassword = $renewDetails['patron']['cat_password'];