From 297ae4b1ce5765b0773bf0140bfa7bb19893ecaf Mon Sep 17 00:00:00 2001
From: Claas Kazzer <kazzer@uni-leipzig.de>
Date: Thu, 7 Apr 2016 19:03:46 +0200
Subject: [PATCH] refs #7364: * W3C fixes for finc theme

---
 module/VuFind/xsl/record-marc.xsl                         | 8 ++++----
 themes/finc/templates/RecordDriver/SolrAI/core.phtml      | 2 +-
 .../finc/templates/RecordDriver/SolrAI/result-list.phtml  | 2 +-
 themes/finc/templates/RecordDriver/SolrDefault/core.phtml | 2 +-
 .../templates/RecordDriver/SolrDefault/result-list.phtml  | 2 +-
 themes/finc/templates/RecordTab/holdingsils.phtml         | 6 +++---
 themes/finc/templates/header.phtml                        | 6 +++---
 7 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/module/VuFind/xsl/record-marc.xsl b/module/VuFind/xsl/record-marc.xsl
index ea4ae78dbf0..e5c2b4f5543 100644
--- a/module/VuFind/xsl/record-marc.xsl
+++ b/module/VuFind/xsl/record-marc.xsl
@@ -11,10 +11,10 @@
   <xsl:template match="marc:record">
       <table class="citation table table-striped">
         <tr class="pace-car">
-          <th width="15%"/>
-          <td width="5%"/>
-          <td width="5%"/>
-          <td width="*"/>
+          <th class="t15-percent"/>
+          <td class="t5-percent"/>
+          <td class="t5-percent"/>
+          <td class="auto-width"/>
         </tr>
         <tr>
           <th>LEADER</th>
diff --git a/themes/finc/templates/RecordDriver/SolrAI/core.phtml b/themes/finc/templates/RecordDriver/SolrAI/core.phtml
index 2f83e1d7c8e..2b6ae9b8641 100644
--- a/themes/finc/templates/RecordDriver/SolrAI/core.phtml
+++ b/themes/finc/templates/RecordDriver/SolrAI/core.phtml
@@ -54,7 +54,7 @@ if($loggedin = $this->auth()->isLoggedIn()) {
 
     <? if ($this->userlist()->getMode() !== 'disabled'): ?>
       <? /* Display the lists that this record is saved to */ ?>
-      <div class="savedLists hide alert-box info" data-alert tabindex="0" aria-live="assertive" role="dialogalert">
+      <div class="savedLists hide alert-box info" data-alert tabindex="0" aria-live="assertive" role="alertdialog">
         <strong><?=$this->transEsc("Saved in")?>:</strong>
       </div>
     <? endif; ?>
diff --git a/themes/finc/templates/RecordDriver/SolrAI/result-list.phtml b/themes/finc/templates/RecordDriver/SolrAI/result-list.phtml
index 885af255d86..7dc6d422e34 100644
--- a/themes/finc/templates/RecordDriver/SolrAI/result-list.phtml
+++ b/themes/finc/templates/RecordDriver/SolrAI/result-list.phtml
@@ -183,7 +183,7 @@
         <? /* Add to favorites */ ?>
            <a href="<?=$this->recordLink()->getActionUrl($this->driver, 'Save')?>" data-lightbox class="save-record" data-id="<?=$this->escapeHtmlAttr($this->driver->getUniqueId()) ?>" title="<?=$this->transEsc('Add to favorites')?>"><i class="fa fa-fw fa-star"></i> <?=$this->transEsc('Add to favorites')?></a><br/>
         <? /* Saved lists */ ?>
-        <div class="savedLists hide alert-box info" data-alert tabindex="0" aria-live="assertive" role="dialogalert">
+        <div class="savedLists hide alert-box info" data-alert tabindex="0" aria-live="assertive" role="alertdialog">
           <strong><?=$this->transEsc("Saved in")?>:</strong>
         </div>
       <? endif; ?>
diff --git a/themes/finc/templates/RecordDriver/SolrDefault/core.phtml b/themes/finc/templates/RecordDriver/SolrDefault/core.phtml
index 37802516574..9c290914115 100644
--- a/themes/finc/templates/RecordDriver/SolrDefault/core.phtml
+++ b/themes/finc/templates/RecordDriver/SolrDefault/core.phtml
@@ -56,7 +56,7 @@ if($loggedin = $this->auth()->isLoggedIn()) {
 
     <? if ($this->userlist()->getMode() !== 'disabled'): ?>
       <? /* Display the lists that this record is saved to */ ?>
-      <div class="savedLists hide alert-box info" data-alert tabindex="0" aria-live="assertive" role="dialogalert">
+      <div class="savedLists hide alert-box info" data-alert tabindex="0" aria-live="assertive" role="alertdialog">
         <strong><?=$this->transEsc("Saved in")?>:</strong>
       </div>
     <? endif; ?>
diff --git a/themes/finc/templates/RecordDriver/SolrDefault/result-list.phtml b/themes/finc/templates/RecordDriver/SolrDefault/result-list.phtml
index 7190ce2aac4..02f3776edaf 100644
--- a/themes/finc/templates/RecordDriver/SolrDefault/result-list.phtml
+++ b/themes/finc/templates/RecordDriver/SolrDefault/result-list.phtml
@@ -180,7 +180,7 @@
             <? /* Add to favorites */ ?>
            <a href="<?=$this->recordLink()->getActionUrl($this->driver, 'Save')?>" data-lightbox class="save-record" data-id="<?=$this->escapeHtmlAttr($this->driver->getUniqueId()) ?>" title="<?=$this->transEsc('Add to favorites')?>"><i class="fa fa-fw fa-star"></i> <?=$this->transEsc('Add to favorites')?></a><br/>
             <? /* Saved lists */ ?>
-            <div class="savedLists hide alert-box info" data-alert tabindex="0" aria-live="assertive" role="dialogalert">
+            <div class="savedLists hide alert-box info" data-alert tabindex="0" aria-live="assertive" role="alertdialog">
               <strong><?=$this->transEsc("Saved in")?>:</strong>
             </div>
           <? endif; ?>
diff --git a/themes/finc/templates/RecordTab/holdingsils.phtml b/themes/finc/templates/RecordTab/holdingsils.phtml
index 1e071d2cccc..c2af65c6987 100644
--- a/themes/finc/templates/RecordTab/holdingsils.phtml
+++ b/themes/finc/templates/RecordTab/holdingsils.phtml
@@ -16,7 +16,7 @@
 <?=$this->context($this)->renderInContext('librarycards/selectcard.phtml', array('user' => $this->auth()->isLoggedIn())); ?>
 
 <? if ($offlineMode == "ils-offline"): ?>
-  <div data-alert class="alert-box warning" tabindex="0" aria-live="assertive" role="dialogalert">
+  <div data-alert class="alert-box warning" tabindex="0" aria-live="assertive" role="alertdialog">
     <h2><?=$this->transEsc('ils_offline_title')?></h2>
     <p><strong><?=$this->transEsc('ils_offline_status')?></strong></p>
     <p><?=$this->transEsc('ils_offline_holdings_message')?></p>
@@ -27,11 +27,11 @@
 <? if (($this->ils()->getHoldsMode() == 'driver' && !empty($holdings)) || $this->ils()->getTitleHoldsMode() == 'driver'): ?>
   <? if ($account->loginEnabled() && $offlineMode != 'ils-offline'): ?>
     <? if (!$user): ?>
-      <div data-alert class="alert-box info" tabindex="0" aria-live="assertive" role="dialogalert">
+      <div data-alert class="alert-box info" tabindex="0" aria-live="assertive" role="alertdialog">
         <a href="<?=$this->recordLink()->getTabUrl($this->driver, 'Holdings')?>?login=true&amp;catalogLogin=true" data-lightbox><?=$this->transEsc("Login")?></a> <?=$this->transEsc("hold_login")?>
       </div>
     <? elseif (!$user->cat_username): ?>
-      <div data-alert class="alert-box info" tabindex="0" aria-live="assertive" role="dialogalert">
+      <div data-alert class="alert-box info" tabindex="0" aria-live="assertive" role="alertdialog">
         <?=$this->translate("hold_profile_html", array('%%url%%' => $this->recordLink()->getTabUrl($this->driver, 'Holdings') . '?catalogLogin=true'))?>
       </div>
     <? endif; ?>
diff --git a/themes/finc/templates/header.phtml b/themes/finc/templates/header.phtml
index 829f020a516..0d38540b79a 100644
--- a/themes/finc/templates/header.phtml
+++ b/themes/finc/templates/header.phtml
@@ -3,7 +3,7 @@
 <nav class="top-bar" data-topbar data-options="sticky_on:all">
   <ul class="title-area">
     <li class="name">
-      <h1><a role="logo" class="navbar-brand" href="<?=$this->url('home')?>"><span class="hide-for-medium-up"><?=$this->transEsc("LibraryName")?></span><img src="<?=$this->imageLink('headerlogo.png')?>" class="hide-for-small" alt="Logo <?=$this->transEsc("LibraryName")?>" title="<?=$this->transEsc("LibraryName")?>"></a></h1>
+      <h1><a class="navbar-brand" href="<?=$this->url('home')?>"><span class="hide-for-medium-up"><?=$this->transEsc("LibraryName")?></span><img src="<?=$this->imageLink('headerlogo.png')?>" class="hide-for-small" alt="Logo <?=$this->transEsc("LibraryName")?>" title="<?=$this->transEsc("LibraryName")?>"></a></h1>
     </li>
     <? /*Remove the class "menu-icon" to get rid of menu icon. Take out "Menu" to just have icon alone */ ?>
     <li class="toggle-topbar menu-icon"><a href="#"><span></span></a></li>
@@ -16,10 +16,10 @@
     <? endif; ?>
     <? if (!isset($this->layout()->renderingError)): ?>
       <? /* Right-hand  Nav Section */ ?>
-      <ul role="navigation" class="right">
+      <ul class="right">
         <? if ($this->feedback()->tabEnabled()): ?>
           <li>
-            <a id="feedbackLink" data-lightbox href="<?=$this->url('feedback-home')?>"><i class="fa fa-envelope"></i> <?=$this->transEsc("Feedback")?></a>
+            <a class="feedbackLink" data-lightbox href="<?=$this->url('feedback-home')?>"><i class="fa fa-envelope"></i> <?=$this->transEsc("Feedback")?></a>
           </li>
         <? endif; ?>
         <? $cart = $this->cart();
-- 
GitLab