diff --git a/module/VuFind/src/VuFind/Session/AbstractBase.php b/module/VuFind/src/VuFind/Session/AbstractBase.php index 4ddfe1a2e0674fadc7dd511ce542859fe3292334..63be861328d1981b7b0de675af31fd217037cc68 100644 --- a/module/VuFind/src/VuFind/Session/AbstractBase.php +++ b/module/VuFind/src/VuFind/Session/AbstractBase.php @@ -81,7 +81,7 @@ abstract class AbstractBase implements SaveHandlerInterface, * @param string $sess_path Session save path * @param string $sess_name Session name * - * @return void + * @return bool * * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ @@ -94,7 +94,7 @@ abstract class AbstractBase implements SaveHandlerInterface, * Close function, this works like a destructor in classes and is executed * when the session operation is done. * - * @return void + * @return bool */ public function close() { @@ -111,12 +111,13 @@ abstract class AbstractBase implements SaveHandlerInterface, * * @param string $sess_id The session ID to destroy * - * @return void + * @return bool */ public function destroy($sess_id) { $table = $this->getTable('Search'); $table->destroySession($sess_id); + return true; } /** @@ -125,7 +126,7 @@ abstract class AbstractBase implements SaveHandlerInterface, * * @param int $sess_maxlifetime Maximum session lifetime. * - * @return void + * @return bool * * @SuppressWarnings(PHPMD.UnusedFormalParameter) */ @@ -142,5 +143,6 @@ abstract class AbstractBase implements SaveHandlerInterface, // Anecdotal testing Today and Yesterday seems to indicate destroy() // is called by the garbage collector and everything is good. // Something to keep in mind though. + return true; } -} \ No newline at end of file +} diff --git a/module/VuFind/src/VuFind/Session/Database.php b/module/VuFind/src/VuFind/Session/Database.php index f2af30e722066ca99d96a32d79e2af177a09226a..c75904be26ca8c11f0f968419e3fa62a19fa422c 100644 --- a/module/VuFind/src/VuFind/Session/Database.php +++ b/module/VuFind/src/VuFind/Session/Database.php @@ -79,7 +79,7 @@ class Database extends AbstractBase * * @param string $sess_id The session ID to destroy * - * @return void + * @return bool */ public function destroy($sess_id) { @@ -88,6 +88,8 @@ class Database extends AbstractBase // Now do database-specific destruction: $this->getTable('Session')->destroySession($sess_id); + + return true; } /** @@ -96,10 +98,11 @@ class Database extends AbstractBase * * @param int $sess_maxlifetime Maximum session lifetime. * - * @return void + * @return bool */ public function gc($sess_maxlifetime) { $this->getTable('Session')->garbageCollect($sess_maxlifetime); + return true; } } diff --git a/module/VuFind/src/VuFind/Session/File.php b/module/VuFind/src/VuFind/Session/File.php index be1690b0aa4dfb7adf87102fc5851c5be938f607..b91331a274609fcbebe83acc3d94722b24692291 100644 --- a/module/VuFind/src/VuFind/Session/File.php +++ b/module/VuFind/src/VuFind/Session/File.php @@ -132,7 +132,7 @@ class File extends AbstractBase * * @param string $sess_id The session ID to destroy * - * @return void + * @return bool */ public function destroy($sess_id) { @@ -153,7 +153,7 @@ class File extends AbstractBase * * @param int $maxlifetime Maximum session lifetime. * - * @return void + * @return bool */ public function gc($maxlifetime) { diff --git a/module/VuFind/src/VuFind/Session/Memcache.php b/module/VuFind/src/VuFind/Session/Memcache.php index 733fc7a86ed9e67f1b6bbdbf80ce568f5e75467f..c23af6ffdde82e8efb4d1e1639dea51e97a0f4cc 100644 --- a/module/VuFind/src/VuFind/Session/Memcache.php +++ b/module/VuFind/src/VuFind/Session/Memcache.php @@ -110,7 +110,7 @@ class Memcache extends AbstractBase * * @param string $sess_id The session ID to destroy * - * @return void + * @return bool */ public function destroy($sess_id) {