From 27815c0fdb2be29a1852601286b0dbaf05bc51c0 Mon Sep 17 00:00:00 2001
From: Robert Lange <robert.lange@uni-leipzig.de>
Date: Wed, 24 Nov 2021 16:07:02 +0100
Subject: [PATCH] refs #20946 [finc] corrects syntactical errors
* add src for ajax skeleton img
* fix for cover: avoid exception for empty file name (FincMissing)
* log exceptions of wachtl loan history call
---
module/finc/src/finc/Cover/Loader.php | 2 +-
module/finc/src/finc/ILS/Driver/LiberoWachtlTrait.php | 3 +++
themes/finc/templates/record/cover.phtml | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/module/finc/src/finc/Cover/Loader.php b/module/finc/src/finc/Cover/Loader.php
index fe853e9f2e7..191c033eedf 100644
--- a/module/finc/src/finc/Cover/Loader.php
+++ b/module/finc/src/finc/Cover/Loader.php
@@ -59,7 +59,7 @@ class Loader extends \VuFind\Cover\Loader
public function loadUnavailable()
{
$this->hasLoadedUnavailable = true;
- if ($this->config->Content->useCoverFallbacksOnFail) {
+ if ($this->config->Content->useCoverFallbacksOnFail && !empty($this->localFile)) {
file_put_contents($this->localFile, self::EMPTY_IMAGE_CONTENT);
}
return parent::loadUnavailable();
diff --git a/module/finc/src/finc/ILS/Driver/LiberoWachtlTrait.php b/module/finc/src/finc/ILS/Driver/LiberoWachtlTrait.php
index ea403ca867f..21fcdc09c3f 100644
--- a/module/finc/src/finc/ILS/Driver/LiberoWachtlTrait.php
+++ b/module/finc/src/finc/ILS/Driver/LiberoWachtlTrait.php
@@ -659,6 +659,9 @@ trait LiberoWachtlTrait
$this->getLiberoWachtlRequestHeaders()
);
} catch (\Exception $e) {
+ $this->debug(
+ 'Error loading loan history from LiberoWachtl: ' . $e->getMessage()
+ );
throw new ILSException($e->getMessage());
}
if (!$result->isSuccess()) {
diff --git a/themes/finc/templates/record/cover.phtml b/themes/finc/templates/record/cover.phtml
index 6ee4c1314de..3d0b10c5e0f 100644
--- a/themes/finc/templates/record/cover.phtml
+++ b/themes/finc/templates/record/cover.phtml
@@ -27,7 +27,7 @@
<div class="cover-container">
<?=$this->render('record/coverReplacement')?>
<a class="coverlink hidden" aria-hidden="true" tabindex="-1">
- <img <?php if ($linkPreview): ?>data-linkpreview="true" <?php endif; ?> class="recordcover ajax" alt="<?=$this->escapeHtmlAttr($alt); ?>" />
+ <img <?php if ($linkPreview): ?>data-linkpreview="true" <?php endif; ?> class="recordcover ajax" src="<?=$this->imageLink('noCover2.gif')?>" alt="<?=$this->escapeHtmlAttr($alt); ?>" />
</a>
<script>
loadCoverByElement({source:'<?=$this->escapeHtmlAttr($driver->getSourceIdentifier())?>', recordId:'<?=$this->escapeHtmlAttr($driver->getUniqueID())?>', size:'<?=$this->escapeHtmlAttr($size)?>'}, $('#<?=$coverId?>'));
--
GitLab