From 21a842fa909e0ae7224dee53169663b4352fba9c Mon Sep 17 00:00:00 2001 From: Robert Lange <robert.lange@uni-leipzig.de> Date: Thu, 30 Sep 2021 17:28:41 +0200 Subject: [PATCH] refs #19392 [finc] Barf for exclude facets * add placeholder filter_name for title translation * use ' instead of " for filter_name in en.ini --- local/languages/en.ini | 2 +- themes/finc/templates/Recommend/SideFacets/single-facet.phtml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/local/languages/en.ini b/local/languages/en.ini index f787ebc22b2..d4787144914 100644 --- a/local/languages/en.ini +++ b/local/languages/en.ini @@ -704,7 +704,7 @@ errorcode_empty_password = "Some data was missing. No password was submitted" errorcode_member_not_found = "The member number does not exist" errorcode_password_validation_error = "Your passed password is not correct" errorcode_empty_req_param_error = "All required fields have to be filled to submit successfully the form" -exclude_filter = "Exclude filter "%%filter_name%%"" +exclude_filter = "Exclude filter '%%filter_name%%'" exclude_newspapers = "Exclude Newspaper Articles" export_download = "Download File" export_exporting = "Creating Export File" diff --git a/themes/finc/templates/Recommend/SideFacets/single-facet.phtml b/themes/finc/templates/Recommend/SideFacets/single-facet.phtml index 672ac1f42a5..00a568ce175 100644 --- a/themes/finc/templates/Recommend/SideFacets/single-facet.phtml +++ b/themes/finc/templates/Recommend/SideFacets/single-facet.phtml @@ -70,7 +70,7 @@ <?php if ($hasSubLinks): ?> <?php $excludeURL = $this->urlBase . $this->url->addFacet($this->group, $this->facet['value'], 'NOT'); ?> - <a href="<?=$excludeURL ?>" data-lightbox-ignore class="exclude" title="<?= $this->transEsc('exclude_filter', ['%%filter_name%%' => $this->facet['displayText']]) ?>, <?= $this->transEsc('page_reload_on_xclude_hint') ?>"> + <a href="<?=$excludeURL ?>" data-lightbox-ignore class="exclude" title="<?= $this->transEsc('exclude_filter', ['%%filter_name%%' => $this->facet['displayText']]) ?>, <?= $this->transEsc('page_reload_on_xclude_hint', ['%%filter_name%%' => $this->facet['displayText']]) ?>"> <i class="fa fa-times" aria-hidden="true"></i> <span class="sr-only"> <?= $this->transEsc('exclude_filter', ['%%filter_name%%' => $this->facet['displayText']]) ?>, <?= $this->transEsc('page_reload_on_xclude_hint', ['%%filter_name%%' => $this->facet['displayText']]) ?> -- GitLab