From 1a784f404c3df0a4d3f9fe8dab3d3b0f2940da1c Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Fri, 6 Jul 2018 10:24:45 -0400
Subject: [PATCH] Avoid problems caused by unset $holdings variable.
---
module/VuFind/src/VuFind/Autocomplete/Suggester.php | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/module/VuFind/src/VuFind/Autocomplete/Suggester.php b/module/VuFind/src/VuFind/Autocomplete/Suggester.php
index cb3c482d0d4..eb3ea0dbff2 100644
--- a/module/VuFind/src/VuFind/Autocomplete/Suggester.php
+++ b/module/VuFind/src/VuFind/Autocomplete/Suggester.php
@@ -128,6 +128,8 @@ class Suggester
list($name, $params) = explode(':', $module, 2);
$handler = $this->pluginManager->get($name);
$handler->setConfig($params);
+ } else {
+ $handler = null;
}
if (is_callable([$handler, 'addFilters'])) {
@@ -139,7 +141,7 @@ class Suggester
$handler->setRequest($request);
}
- return (isset($handler) && is_object($handler))
+ return is_object($handler)
? array_values($handler->getSuggestions($query)) : [];
}
}
--
GitLab