From 19b6c2d338e1b07e26061836bacad2708e2e68f5 Mon Sep 17 00:00:00 2001
From: Demian Katz <demian.katz@villanova.edu>
Date: Tue, 27 Sep 2016 11:17:26 -0400
Subject: [PATCH] Expanded cart tests.
---
.../src/VuFindTest/Mink/CartTest.php | 167 +++++++++++++++++-
1 file changed, 161 insertions(+), 6 deletions(-)
diff --git a/module/VuFind/tests/integration-tests/src/VuFindTest/Mink/CartTest.php b/module/VuFind/tests/integration-tests/src/VuFindTest/Mink/CartTest.php
index 661fe73057c..bc7ade8d84c 100644
--- a/module/VuFind/tests/integration-tests/src/VuFindTest/Mink/CartTest.php
+++ b/module/VuFind/tests/integration-tests/src/VuFindTest/Mink/CartTest.php
@@ -64,6 +64,21 @@ class CartTest extends \VuFindTest\Unit\MinkTestCase
return $session->getPage();
}
+ /**
+ * Get a reference to a standard search results page.
+ *
+ * @param string $id Record ID to load.
+ *
+ * @return Element
+ */
+ protected function getRecordPage($id)
+ {
+ $session = $this->getMinkSession();
+ $path = '/Record/' . urlencode($id);
+ $session->visit($this->getVuFindUrl() . $path);
+ return $session->getPage();
+ }
+
/**
* Click the "add to cart" button with nothing selected; fail if this does
* not display an appropriate message.
@@ -92,6 +107,34 @@ class CartTest extends \VuFindTest\Unit\MinkTestCase
$this->fail('Too many retries on check for error message.');
}
+ /**
+ * Click the "add to cart" button with duplicate IDs selected; fail if this does
+ * not display an appropriate message.
+ *
+ * @param Element $page Page element
+ * @param Element $updateCart Add to cart button
+ *
+ * @return void
+ */
+ protected function tryAddingDuplicatesToCart(Element $page, Element $updateCart)
+ {
+ // This test is a bit timing-sensitive, so introduce a retry loop before
+ // completely failing.
+ for ($clickRetry = 0; $clickRetry <= 4; $clickRetry++) {
+ $updateCart->click();
+ $content = $page->find('css', '.popover-content');
+ if (is_object($content)) {
+ $this->assertEquals(
+ '0 item(s) added to your Book Bag 2 item(s) are either '
+ . 'already in your Book Bag or could not be added',
+ $content->getText()
+ );
+ return;
+ }
+ }
+ $this->fail('Too many retries on check for error message.');
+ }
+
/**
* Add the current page of results to the cart.
*
@@ -131,17 +174,13 @@ class CartTest extends \VuFindTest\Unit\MinkTestCase
protected function setUpGenericCartTest($extraConfigs = [])
{
// Activate the cart:
- $extraConfigs['config']['Site']
- = ['showBookBag' => true, 'theme' => 'bootprint3'];
- $extraConfigs['config']['Mail']
- = ['testOnly' => 1];
+ $extraConfigs['config']['Site'] = ['showBookBag' => true];
$this->changeConfigs($extraConfigs);
$page = $this->getSearchResultsPage();
// Click "add" without selecting anything.
$updateCart = $this->findCss($page, '#updateCart');
- $this->tryAddingNothingToCart($page, $updateCart);
// Now actually select something:
$this->addCurrentPageToCart($page, $updateCart);
@@ -214,6 +253,120 @@ class CartTest extends \VuFindTest\Unit\MinkTestCase
$cartSelectAll->check();
}
+ /**
+ * Test that adding nothing to the cart triggers an appropriate message.
+ *
+ * @return void
+ */
+ public function testAddingNothing()
+ {
+ // Activate the cart:
+ $this->changeConfigs(['config' => ['Site' => ['showBookBag' => true]]]);
+
+ $page = $this->getSearchResultsPage();
+
+ // Click "add" without selecting anything.
+ $updateCart = $this->findCss($page, '#updateCart');
+ $this->tryAddingNothingToCart($page, $updateCart);
+ }
+
+ /**
+ * Test that adding the same records to the cart multiple times triggers an
+ * appropriate message.
+ *
+ * @return void
+ */
+ public function testAddingDuplicates()
+ {
+ // Activate the cart:
+ $this->changeConfigs(['config' => ['Site' => ['showBookBag' => true]]]);
+
+ $page = $this->getSearchResultsPage();
+
+ // Now select the same things twice:
+ $updateCart = $this->findCss($page, '#updateCart');
+ $this->addCurrentPageToCart($page, $updateCart);
+ $this->assertEquals('2', $this->findCss($page, '#cartItems strong')->getText());
+ $this->tryAddingDuplicatesToCart($page, $updateCart);
+ $this->assertEquals('2', $this->findCss($page, '#cartItems strong')->getText());
+ }
+
+ /**
+ * Test that the cart limit is enforced from search results.
+ *
+ * @return void
+ */
+ public function testOverfillingCart()
+ {
+ // Activate the cart:
+ $this->changeConfigs(
+ ['config' => ['Site' => ['showBookBag' => true, 'bookBagMaxSize' => 1]]]
+ );
+
+ $page = $this->getSearchResultsPage();
+
+ // Now select the same things twice:
+ $updateCart = $this->findCss($page, '#updateCart');
+ $this->addCurrentPageToCart($page, $updateCart);
+ $this->assertEquals('1', $this->findCss($page, '#cartItems strong')->getText());
+ }
+
+ /**
+ * Test that the cart limit is enforced from record pages.
+ *
+ * @return void
+ */
+ public function testOverfillingCartFromRecordPage()
+ {
+ // Activate the cart:
+ $this->changeConfigs(
+ ['config' => ['Site' => ['showBookBag' => true, 'bookBagMaxSize' => 1]]]
+ );
+
+ $page = $this->getRecordPage('testsample1');
+
+ // Test that we can toggle the cart item back and forth:
+ $cartItems = $this->findCss($page, '#cartItems');
+ $add = $this->findCss($page, '.cart-add');
+ $remove = $this->findCss($page, '.cart-remove');
+ $add->click();
+ $this->assertEquals('1 items (Full)', $cartItems->getText());
+ $remove->click();
+ $this->assertEquals('0 items', $cartItems->getText());
+ $add->click();
+ $this->assertEquals('1 items (Full)', $cartItems->getText());
+
+ // Now move to another page and try to add a second item -- it should
+ // not be added due to cart limit:
+ $page = $this->getRecordPage('testsample2');
+ $cartItems = $this->findCss($page, '#cartItems');
+ $add = $this->findCss($page, '.cart-add');
+ $add->click();
+ $this->assertEquals('1 items (Full)', $cartItems->getText());
+ }
+
+ /**
+ * Test that the record "add to cart" button functions.
+ *
+ * @return void
+ */
+ public function testAddingMultipleRecordsFromRecordPage()
+ {
+ // Activate the cart:
+ $this->changeConfigs(
+ ['config' => ['Site' => ['showBookBag' => true]]]
+ );
+
+ // Test that we can add multiple records:
+ for ($x = 1; $x <= 3; $x++) {
+ $page = $this->getRecordPage('testsample' . $x);
+ $this->findCss($page, '.cart-add')->click();
+ $this->assertEquals(
+ $x . ' items', $this->findCss($page, '#cartItems')->getText()
+ );
+ }
+ }
+
/**
* Test that we can put items in the cart and then remove them with the
* delete control.
@@ -279,7 +432,9 @@ class CartTest extends \VuFindTest\Unit\MinkTestCase
*/
public function testCartEmail()
{
- $page = $this->setUpGenericCartTest();
+ $page = $this->setUpGenericCartTest(
+ ['config' => ['Mail' => ['testOnly' => 1]]]
+ );
$button = $this->findCss($page, '.cart-controls button[name=email]');
// First try clicking without selecting anything:
--
GitLab