From 0de0e419c1668df48abb2287ec73495224949865 Mon Sep 17 00:00:00 2001
From: Robert Lange <robert.lange@uni-leipzig.de>
Date: Mon, 27 Mar 2023 14:44:53 +0200
Subject: [PATCH] refs #23517 [finc] use specifc translation keys for tooltips
 in account menu

* change translation for holds tooltip in account menu
---
 local/languages/de.ini                    | 10 +++++++++
 local/languages/en.ini                    | 10 +++++++++
 themes/finc/js/account_ajax.js            | 25 +++++++++++------------
 themes/finc/templates/layout/layout.phtml | 11 +++++++++-
 4 files changed, 42 insertions(+), 14 deletions(-)

diff --git a/local/languages/de.ini b/local/languages/de.ini
index 0e8dc6676e6..9ca0cb8c1ef 100644
--- a/local/languages/de.ini
+++ b/local/languages/de.ini
@@ -2116,3 +2116,13 @@ No linguistic content = "Nichtsprachlicher Inhalt"
 # Collections Search
 Search Collection Items = "Enthaltene Objekte durchsuchen"
 sidebar_expand_collections = "Ergebnisse weiter eingrenzen"
+
+renew_checkedout_item_due_tooltip = "Bald fällige Ausleihen"
+renew_checkedout_item_overdue_tooltip = "Überfällige Ausleihen"
+renew_permanentloans_item_due_tooltip = "Bald fällige Ausleihen"
+renew_permanentloans_item_overdue_tooltip = "Überfällige Ausleihen"
+holds_available_tooltip = "Abholbereit"
+holds_in_transit_tooltip = "Unterwegs zum Abholort"
+storageretrievalrequest_available_tooltip = "Abholbereit"
+storageretrievalrequest_in_transit_tooltip = "Unterwegs zum Abholort"
+mediareadtopickup_tooltip = "Abholbereit"
\ No newline at end of file
diff --git a/local/languages/en.ini b/local/languages/en.ini
index 795f267899a..63e7bbbb1dc 100644
--- a/local/languages/en.ini
+++ b/local/languages/en.ini
@@ -2202,3 +2202,13 @@ No linguistic content = "No linguistic content"
 # Collections Search
 Search Collection Items = "Search Collection Items"
 sidebar_expand_collections = "Filter Collection Items"
+
+renew_checkedout_item_due_tooltip = "Items due soon"
+renew_checkedout_item_overdue_tooltip = "Items overdue"
+renew_permanentloans_item_due_tooltip = "Items due soon"
+renew_permanentloans_item_overdue_tooltip = "Items overdue"
+holds_available_tooltip = "Available for Pickup"
+holds_in_transit_tooltip = "In Transit to Pickup Location"
+storageretrievalrequest_available_tooltip = "Available for Pickup"
+storageretrievalrequest_in_transit_tooltip = "In Transit to Pickup Location"
+mediareadtopickup_tooltip = "Available for Pickup"
\ No newline at end of file
diff --git a/themes/finc/js/account_ajax.js b/themes/finc/js/account_ajax.js
index ffaae15708a..04cfb8dfeb9 100644
--- a/themes/finc/js/account_ajax.js
+++ b/themes/finc/js/account_ajax.js
@@ -216,11 +216,11 @@ $(document).ready(function registerAccountAjax() {
         html += '<span class="badge ok" data-toggle="tooltip" title="' + VuFind.translate('account_normal_checkouts') + '">' + status.ok + '</span>';
       }
       if (status.warn > 0) {
-        html += '<span class="badge warn" data-toggle="tooltip" title="' + VuFind.translate('account_checkouts_due') + '">' + status.warn + '</span>';
+        html += '<span class="badge warn" data-toggle="tooltip" title="' + VuFind.translate('renew_checkedout_item_due_tooltip') + '">' + status.warn + '</span>';
         level = ICON_LEVELS.WARNING;
       }
       if (status.overdue > 0) {
-        html += '<span class="badge overdue" data-toggle="tooltip" title="' + VuFind.translate('account_checkouts_overdue') + '">' + status.overdue + '</span>';
+        html += '<span class="badge overdue" data-toggle="tooltip" title="' + VuFind.translate('renew_checkedout_item_overdue_tooltip') + '">' + status.overdue + '</span>';
         level = ICON_LEVELS.DANGER;
       }
       $element.html(html);
@@ -237,14 +237,13 @@ $(document).ready(function registerAccountAjax() {
     selector: ".mediareadytopickup-status",
     ajaxMethod: "getUserMediaReadyToPickup",
     render: function render($element, status, ICON_LEVELS) {
-      var level = ICON_LEVELS.NONE;
       if (status.available > 0) {
-        $element.html('<i class="fa fa-bell text-success" data-toggle="tooltip" title="' + VuFind.translate('account_requests_available') + '"></i>');
+        $element.html('<i class="fa fa-bell text-success" data-toggle="tooltip" title="' + VuFind.translate('mediareadtopickup_tooltip') + '"></i>');
         level = ICON_LEVELS.GOOD;
       } else if (status.in_transit > 0) {
         $element.html('<i class="fa fa-clock-o text-warning" data-toggle="tooltip" title="' + VuFind.translate('account_requests_in_transit') + '"></i>');
       } else {
-        $element.addClass("holds-status hidden");
+        $element.addClass("hidden");
       }
       $('[data-toggle="tooltip"]', $element).tooltip();
       return level;
@@ -265,11 +264,11 @@ $(document).ready(function registerAccountAjax() {
         html += '<span class="badge ok" data-toggle="tooltip" title="' + VuFind.translate('account_normal_checkouts') + '">' + status.ok + '</span>';
       }
       if (status.warn > 0) {
-        html += '<span class="badge warn" data-toggle="tooltip" title="' + VuFind.translate('account_checkouts_due') + '">' + status.warn + '</span>';
+        html += '<span class="badge warn" data-toggle="tooltip" title="' + VuFind.translate('renew_permanentloans_item_due_tooltip') + '">' + status.warn + '</span>';
         level = ICON_LEVELS.WARNING;
       }
       if (status.overdue > 0) {
-        html += '<span class="badge overdue" data-toggle="tooltip" title="' + VuFind.translate('account_checkouts_overdue') + '">' + status.overdue + '</span>';
+        html += '<span class="badge overdue" data-toggle="tooltip" title="' + VuFind.translate('renew_permanentloans_item_overdue_tooltip') + '">' + status.overdue + '</span>';
         level = ICON_LEVELS.DANGER;
       }
       $element.html(html);
@@ -287,12 +286,12 @@ $(document).ready(function registerAccountAjax() {
     render: function render($element, status, ICON_LEVELS) {
       var level = ICON_LEVELS.NONE;
       if (status.available > 0) {
-        $element.html('<i class="fa fa-bell text-success" data-toggle="tooltip" title="' + VuFind.translate('account_requests_available') + '"></i>');
+        $element.html('<i class="fa fa-bell text-success" data-toggle="tooltip" title="' + VuFind.translate('holds_available_tooltip') + '"></i>');
         level = ICON_LEVELS.GOOD;
       } else if (status.in_transit > 0) {
-        $element.html('<i class="fa fa-clock-o text-warning" data-toggle="tooltip" title="' + VuFind.translate('account_requests_in_transit') + '"></i>');
+        $element.html('<i class="fa fa-clock-o text-warning" data-toggle="tooltip" title="' + VuFind.translate('holds_in_transit_tooltip') + '"></i>');
       } else {
-        $element.addClass("holds-status hidden");
+        $element.addClass("hidden");
       }
       $('[data-toggle="tooltip"]', $element).tooltip();
       return level;
@@ -308,12 +307,12 @@ $(document).ready(function registerAccountAjax() {
     render: function render($element, status, ICON_LEVELS) {
       var level = ICON_LEVELS.NONE;
       if (status.available > 0) {
-        $element.html('<i class="fa fa-bell text-success" data-toggle="tooltip" title="' + VuFind.translate('account_requests_available') + '"></i>');
+        $element.html('<i class="fa fa-bell text-success" data-toggle="tooltip" title="' + VuFind.translate('storageretrievalrequest_available_tooltip') + '"></i>');
         level = ICON_LEVELS.GOOD;
       } else if (status.in_transit > 0) {
-        $element.html('<i class="fa fa-clock-o text-warning" data-toggle="tooltip" title="' + VuFind.translate('account_requests_in_transit') + '"></i>');
+        $element.html('<i class="fa fa-clock-o text-warning" data-toggle="tooltip" title="' + VuFind.translate('storageretrievalrequest_in_transit_tooltip') + '"></i>');
       } else {
-        $element.addClass("holds-status hidden");
+        $element.addClass("hidden");
       }
       $('[data-toggle="tooltip"]', $element).tooltip();
       return level;
diff --git a/themes/finc/templates/layout/layout.phtml b/themes/finc/templates/layout/layout.phtml
index 1fa8f728437..de0bf8acf23 100644
--- a/themes/finc/templates/layout/layout.phtml
+++ b/themes/finc/templates/layout/layout.phtml
@@ -153,7 +153,16 @@
         'account_requests_available' => 'account_requests_available',
         'account_requests_in_transit' => 'account_requests_in_transit',
         'Interlibrary Loan Requests' => 'Interlibrary Loan Requests',
-        'Permanent Checked Out Items' => 'Permanent Checked Out Items'
+        'Permanent Checked Out Items' => 'Permanent Checked Out Items',
+        'renew_checkedout_item_due_tooltip' => 'renew_checkedout_item_due_tooltip',
+        'renew_checkedout_item_overdue_tooltip' => 'renew_checkedout_item_overdue_tooltip',
+        'renew_permanentloans_item_due_tooltip' => 'renew_permanentloans_item_due_tooltip',
+        'renew_permanentloans_item_overdue_tooltip' => 'renew_permanentloans_item_overdue_tooltip',
+        'holds_available_tooltip' => 'holds_available_tooltip',
+        'holds_in_transit_tooltip' => 'holds_in_transit_tooltip',
+        'storageretrievalrequest_available_tooltip' => 'storageretrievalrequest_available_tooltip',
+        'storageretrievalrequest_in_transit_tooltip' => 'storageretrievalrequest_in_transit_tooltip',
+        'mediareadtopickup_tooltip' => 'mediareadtopickup_tooltip'
       ]
     );
   }
-- 
GitLab