From 05792e070462d93785e1693210062e325e4836e5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathias=20Maa=C3=9F?= <mathias.maass@uni-leipzig.de> Date: Fri, 12 May 2023 10:45:27 +0200 Subject: [PATCH] refs #23646 [finc] add aria-hidden to coins spans --- .../templates/RecordDriver/EDS/result-list.phtml | 2 +- .../finc/templates/RecordDriver/DefaultRecord/list-entry.phtml | 2 +- .../finc/templates/RecordDriver/DefaultRecord/result-list.phtml | 2 +- .../finc/templates/RecordDriver/FincMissing/result-list.phtml | 2 +- themes/finc/templates/RecordDriver/SolrAI/result-list.phtml | 2 +- themes/finc/templates/myresearch/checkedout.phtml | 2 +- themes/finc/templates/myresearch/historicloans.phtml | 2 +- themes/finc/templates/myresearch/holds.phtml | 2 +- themes/finc/templates/myresearch/illrequests.phtml | 2 +- themes/finc/templates/myresearch/storageretrievalrequests.phtml | 2 +- themes/finc/templates/record/view.phtml | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/themes/finc-accessibility/templates/RecordDriver/EDS/result-list.phtml b/themes/finc-accessibility/templates/RecordDriver/EDS/result-list.phtml index 24f8e44d39e..6e5e4cd6d17 100644 --- a/themes/finc-accessibility/templates/RecordDriver/EDS/result-list.phtml +++ b/themes/finc-accessibility/templates/RecordDriver/EDS/result-list.phtml @@ -153,7 +153,7 @@ <?php endforeach; ?> <?php endif; ?> - <?=(!$restrictedView && $this->driver->supportsCoinsOpenUrl())?'<span class="Z3988" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenUrl()) . '"></span>':''?> + <?=(!$restrictedView && $this->driver->supportsCoinsOpenUrl())?'<span class="Z3988" aria-hidden="true" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenUrl()) . '"></span>':''?> </div> </div> <?php if ($thumbnail && $thumbnailAlignment == 'right'): ?> diff --git a/themes/finc/templates/RecordDriver/DefaultRecord/list-entry.phtml b/themes/finc/templates/RecordDriver/DefaultRecord/list-entry.phtml index 68faef14f9b..e924df0fcaa 100644 --- a/themes/finc/templates/RecordDriver/DefaultRecord/list-entry.phtml +++ b/themes/finc/templates/RecordDriver/DefaultRecord/list-entry.phtml @@ -274,7 +274,7 @@ </ul> </div> - <?=$this->driver->supportsCoinsOpenUrl()?'<span class="Z3988" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenUrl()) . '"></span>':''?> + <?=$this->driver->supportsCoinsOpenUrl()?'<span class="Z3988" aria-hidden="true" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenUrl()) . '"></span>':''?> <?php endif; ?> </div> </div> diff --git a/themes/finc/templates/RecordDriver/DefaultRecord/result-list.phtml b/themes/finc/templates/RecordDriver/DefaultRecord/result-list.phtml index 75e7fdc3b2a..687196e5be0 100644 --- a/themes/finc/templates/RecordDriver/DefaultRecord/result-list.phtml +++ b/themes/finc/templates/RecordDriver/DefaultRecord/result-list.phtml @@ -259,7 +259,7 @@ if ($cover): <?php endforeach; ?> <?php endif; ?> - <?=$this->driver->supportsCoinsOpenUrl()?'<span class="Z3988" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenUrl()) . '"></span>':''?> + <?=$this->driver->supportsCoinsOpenUrl()?'<span class="Z3988" aria-hidden="true" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenUrl()) . '"></span>':''?> </div> </div> <?php if ($thumbnail && $thumbnailAlignment == 'right'): ?> diff --git a/themes/finc/templates/RecordDriver/FincMissing/result-list.phtml b/themes/finc/templates/RecordDriver/FincMissing/result-list.phtml index 846634e63e9..69f1f767c58 100644 --- a/themes/finc/templates/RecordDriver/FincMissing/result-list.phtml +++ b/themes/finc/templates/RecordDriver/FincMissing/result-list.phtml @@ -66,7 +66,7 @@ if ($cover): <div class="result-links hidden-print"> <?php /* We don't display any interaction buttons for missing records - CK */ ?> - <?=$this->driver->supportsCoinsOpenUrl() ? '<span class="Z3988" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenUrl()) . '"></span>' : ''?> + <?=$this->driver->supportsCoinsOpenUrl() ? '<span class="Z3988" aria-hidden="true" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenUrl()) . '"></span>' : ''?> </div> </div> <?php if ($thumbnail && $thumbnailAlignment == 'right'): ?> diff --git a/themes/finc/templates/RecordDriver/SolrAI/result-list.phtml b/themes/finc/templates/RecordDriver/SolrAI/result-list.phtml index b92b8ba6b86..a9c08f9fae6 100644 --- a/themes/finc/templates/RecordDriver/SolrAI/result-list.phtml +++ b/themes/finc/templates/RecordDriver/SolrAI/result-list.phtml @@ -237,7 +237,7 @@ if ($cover): <?php endforeach; ?> <?php endif; ?> - <?=$this->driver->supportsCoinsOpenUrl() ? '<span class="Z3988" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenUrl()) . '"></span>' : ''?> + <?=$this->driver->supportsCoinsOpenUrl() ? '<span class="Z3988" aria-hidden="true" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenUrl()) . '"></span>' : ''?> </div> </div> <?php if ($thumbnail && $thumbnailAlignment == 'right'): ?> diff --git a/themes/finc/templates/myresearch/checkedout.phtml b/themes/finc/templates/myresearch/checkedout.phtml index 38bfb7a461b..9dadf1d4b29 100644 --- a/themes/finc/templates/myresearch/checkedout.phtml +++ b/themes/finc/templates/myresearch/checkedout.phtml @@ -212,7 +212,7 @@ <?=$thumbnail ?> <?php endif ?> </div> - <?=$resource->tryMethod('supportsCoinsOpenUrl') ? '<span class="Z3988" title="' . $this->escapeHtmlAttr($resource->getCoinsOpenUrl()) . '"></span>' : ''?> + <?=$resource->tryMethod('supportsCoinsOpenUrl') ? '<span class="Z3988" aria-hidden="true" title="' . $this->escapeHtmlAttr($resource->getCoinsOpenUrl()) . '"></span>' : ''?> </li> <?php endforeach; ?> </ul> diff --git a/themes/finc/templates/myresearch/historicloans.phtml b/themes/finc/templates/myresearch/historicloans.phtml index 23e2d7c11d1..020fc349366 100644 --- a/themes/finc/templates/myresearch/historicloans.phtml +++ b/themes/finc/templates/myresearch/historicloans.phtml @@ -130,7 +130,7 @@ <?=$thumbnail ?> <?php endif ?> </div> - <?=$resource->tryMethod('supportsCoinsOpenUrl')?'<span class="Z3988" title="' . $this->escapeHtmlAttr($resource->getCoinsOpenUrl()) . '"></span>':''?> + <?=$resource->tryMethod('supportsCoinsOpenUrl')?'<span class="Z3988" aria-hidden="true" title="' . $this->escapeHtmlAttr($resource->getCoinsOpenUrl()) . '"></span>':''?> </li> <?php endforeach; ?> </ul> diff --git a/themes/finc/templates/myresearch/holds.phtml b/themes/finc/templates/myresearch/holds.phtml index 657ca99acd9..7ac69946919 100644 --- a/themes/finc/templates/myresearch/holds.phtml +++ b/themes/finc/templates/myresearch/holds.phtml @@ -186,7 +186,7 @@ <?=$thumbnail ?> <?php endif ?> </div> - <?=$resource->tryMethod('supportsCoinsOpenUrl')?'<span class="Z3988" title="' . $this->escapeHtmlAttr($resource->getCoinsOpenUrl()) . '"></span>':''?> + <?=$resource->tryMethod('supportsCoinsOpenUrl')?'<span class="Z3988" aria-hidden="true" title="' . $this->escapeHtmlAttr($resource->getCoinsOpenUrl()) . '"></span>':''?> </li> <?php endforeach; ?> </ul> diff --git a/themes/finc/templates/myresearch/illrequests.phtml b/themes/finc/templates/myresearch/illrequests.phtml index c0d38e14da0..b6f8dfe7141 100644 --- a/themes/finc/templates/myresearch/illrequests.phtml +++ b/themes/finc/templates/myresearch/illrequests.phtml @@ -180,7 +180,7 @@ <?=$thumbnail ?> <?php endif ?> </div> - <?=$resource->tryMethod('supportsCoinsOpenUrl')?'<span class="Z3988" title="' . $this->escapeHtmlAttr($resource->getCoinsOpenUrl()) . '"></span>':''?> + <?=$resource->tryMethod('supportsCoinsOpenUrl')?'<span class="Z3988" aria-hidden="true" title="' . $this->escapeHtmlAttr($resource->getCoinsOpenUrl()) . '"></span>':''?> </li> <?php endforeach; ?> </ul> diff --git a/themes/finc/templates/myresearch/storageretrievalrequests.phtml b/themes/finc/templates/myresearch/storageretrievalrequests.phtml index 2e465f57b2a..f550771a650 100644 --- a/themes/finc/templates/myresearch/storageretrievalrequests.phtml +++ b/themes/finc/templates/myresearch/storageretrievalrequests.phtml @@ -177,7 +177,7 @@ <?=$thumbnail ?> <?php endif ?> </div> - <?=$resource->tryMethod('supportsCoinsOpenUrl') ? '<span class="Z3988" title="' . $this->escapeHtmlAttr($resource->getCoinsOpenUrl()) . '"></span>' : ''?> + <?=$resource->tryMethod('supportsCoinsOpenUrl') ? '<span class="Z3988" aria-hidden="true" title="' . $this->escapeHtmlAttr($resource->getCoinsOpenUrl()) . '"></span>' : ''?> </li> <?php endforeach; ?> </ul> diff --git a/themes/finc/templates/record/view.phtml b/themes/finc/templates/record/view.phtml index a1c0928add8..94ecb65394a 100644 --- a/themes/finc/templates/record/view.phtml +++ b/themes/finc/templates/record/view.phtml @@ -117,7 +117,7 @@ </div> <?php endif; ?> - <?=$this->driver->supportsCoinsOpenURL()?'<span class="Z3988" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenURL()) . '"></span>':''?> + <?=$this->driver->supportsCoinsOpenURL()?'<span class="Z3988" aria-hidden="true" title="' . $this->escapeHtmlAttr($this->driver->getCoinsOpenURL()) . '"></span>':''?> </div> <?php /* finc: use 'section' for sidebar #23430; -- GitLab