From 027a736418419677579f541235d1a24d5d4d36de Mon Sep 17 00:00:00 2001
From: Chris Hallberg <crhallberg@gmail.com>
Date: Thu, 9 Jul 2020 17:36:45 -0400
Subject: [PATCH] Fix Lightbox Title (#1674)

---
 themes/bootstrap3/less/components/lightbox.less   | 7 +++++++
 themes/bootstrap3/templates/layout/layout.phtml   | 5 ++---
 themes/bootstrap3/templates/layout/lightbox.phtml | 1 -
 3 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/themes/bootstrap3/less/components/lightbox.less b/themes/bootstrap3/less/components/lightbox.less
index 207faecbca4..32da48c274b 100644
--- a/themes/bootstrap3/less/components/lightbox.less
+++ b/themes/bootstrap3/less/components/lightbox.less
@@ -34,6 +34,13 @@
   margin-bottom: 1.3rem;
 }
 
+#modal-title {
+  display: block;
+  padding: 0.8rem 1rem 0.7rem;
+  font-size: 23px;
+  font-weight: normal;
+}
+
 #modal .cart-controls .btn { margin-bottom: 4px; }
 #modal .cart-controls .checkbox { padding-bottom: 1rem; }
 #modal .cart-controls ~ hr { margin-top: 0; }
diff --git a/themes/bootstrap3/templates/layout/layout.phtml b/themes/bootstrap3/templates/layout/layout.phtml
index aa07ed7b8c9..12631e89bf7 100644
--- a/themes/bootstrap3/templates/layout/layout.phtml
+++ b/themes/bootstrap3/templates/layout/layout.phtml
@@ -196,9 +196,8 @@ JS;
       <div class="modal-dialog">
         <div class="modal-content">
           <button type="button" class="close" data-dismiss="modal" aria-hidden="true">&times;</button>
-          <div class="modal-body">
-            <span id="modal-title"><?=$this->transEsc('Loading') ?>...</span>
-          </div>
+          <span id="modal-title" role="heading"><?=$this->transEsc('Loading') ?>...</span>
+          <div class="modal-body"></div>
         </div>
       </div>
     </div>
diff --git a/themes/bootstrap3/templates/layout/lightbox.phtml b/themes/bootstrap3/templates/layout/lightbox.phtml
index d54f7effce8..dbde8d57ff6 100644
--- a/themes/bootstrap3/templates/layout/lightbox.phtml
+++ b/themes/bootstrap3/templates/layout/lightbox.phtml
@@ -1,4 +1,3 @@
-<span id="modal-title" hidden><?=$this->headTitle()->renderTitle() ?></span>
 <?=$this->layout()->content?>
 <?=$this->piwik(['lightbox' => true])?>
 <?=$this->googleanalytics($this->serverUrl(true))?>
-- 
GitLab